refactor: reenable recommended eslint rules

[adamalston]

Closes https://github.com/carbon-design-system/carbon/issues/19007

Reenable recommendeded ESLint rules.

Changelog

Changed

• Reenable recommendeded ESLint rules.

Testing / Reviewing

yarn lint

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

• [x] Reviewed every line of the diff
• [ ] ~Updated documentation and storybook examples~
• [ ] ~Wrote passing tests that cover this change~
• [x] Addressed any impact on accessibility (a11y)
• [x] Tested for cross-browser consistency
• [x] Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

[netlify[bot]]

✅ Deploy Preview for v11-carbon-web-components ready!

Name	Link
🔨 Latest commit	9b960db7f2b6d05700e96f39c1521666918c273d
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-web-components/deploys/685350876a04280008b6b627
😎 Deploy Preview	https://deploy-preview-19657--v11-carbon-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify[bot]]

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	9b960db7f2b6d05700e96f39c1521666918c273d
🔍 Latest deploy log	https://app.netlify.com/projects/v11-carbon-react/deploys/6853508750c62b0008498297
😎 Deploy Preview	https://deploy-preview-19657--v11-carbon-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.83%. Comparing base (faed0de) to head (9b960db). Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #19657   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files         371      371           
  Lines       14773    14773           
  Branches     4843     4872   +29     
=======================================
  Hits        12532    12532           
  Misses       2091     2091           
  Partials      150      150           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adamalston]

Hi @2nikhiltom, you added some unused code in https://github.com/carbon-design-system/carbon/pull/19043, which I’ve removed in this pull request. Just pinging you in case that code was intended to be used. If it wasn't intended to be used, LONG_LABEL_NODE_1 could probably be renamed to LONG_LABEL_NODE for clarity and consistency with SHORT_LABEL_NODE.

Edit: Actually, anyone who manually merges main into their branch will encounter a lint-staged error related to LONG_LABEL_NODE_1, because https://github.com/carbon-design-system/carbon/pull/19658 was merged. That PR should cause the variable to be flagged as unused due to the @typescript-eslint/no-unused-vars rule that's set via tseslint.configs.strict.

[netlify[bot]]

✅ Deploy Preview for carbon-elements ready!

Name	Link
🔨 Latest commit	9b960db7f2b6d05700e96f39c1521666918c273d
🔍 Latest deploy log	https://app.netlify.com/projects/carbon-elements/deploys/68535087f140470007812502
😎 Deploy Preview	https://deploy-preview-19657--carbon-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[2nikhiltom]

Hey @adamalston , great catch ! thanks. Yes LONG_LABEL_NODE_1 could be renamed to LONG_LABEL_NODE .