carbon
carbon copied to clipboard
fix(TimePicker): Assignment of className props only to the container element
Closes https://github.com/carbon-design-system/carbon/issues/19518
Changelog
Changed
- Updated unit test cases
- Assigning of "className" property to the TimePicker Node and TimePicker Input Node
- Two props (inputClassName and pickerClassName) are introduced to handle the backward compatibility
Testing / Reviewing
- Define the "className" attribute for the TimePicker Component
- Inspect the DOM Element
For example,
<TimePicker id="time-picker" className="time-picker-container" />
For the above component, DOM would be rendered like,
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [X] Reviewed every line of the diff
- [X] Updated documentation and storybook examples
- [X] Wrote passing tests that cover this change ~~Addressed any impact on accessibility (a11y)~~ ~~Tested for cross-browser consistency~~
- [X] Validated that this code is ready for review and status checks should pass
More details can be found in the pull request guide
All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.
Deploy Preview for v11-carbon-web-components ready!
| Name | Link |
|---|---|
| Latest commit | 651e810b377cd82985a109dbc0ed74e565378dc5 |
| Latest deploy log | https://app.netlify.com/projects/v11-carbon-web-components/deploys/6846718233740f0008bc0fd4 |
| Deploy Preview | https://deploy-preview-19573--v11-carbon-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
I have read the DCO document and I hereby sign the DCO.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 28baf4ceacc44464aa64775923f9e87cb358d091 |
| Latest deploy log | https://app.netlify.com/projects/v11-carbon-react/deploys/684672b63e2b3a0008ad1f2e |
| Deploy Preview | https://deploy-preview-19573--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
recheck
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.65%. Comparing base (
639bce3) to head (28baf4c). Report is 62 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #19573 +/- ##
=======================================
Coverage 84.65% 84.65%
=======================================
Files 373 373
Lines 14715 14715
Branches 4846 4796 -50
=======================================
Hits 12457 12457
Misses 2108 2108
Partials 150 150
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.