carbon
carbon copied to clipboard
feat(slider): resolve parity issue two handle skeleton
Closes #18473
The two handle skelton feature, available in React but missing in Web Components, is being added to Web Components.
Changelog
New
- The two handle skelton feature has been added.
- Style issue with existing skelton feature is fixed.
Testing / Reviewing
Go to Slider stories in storybook and it should have a working Two handle skelton story under it.
Deploy Preview for v11-carbon-web-components ready!
| Name | Link |
|---|---|
| Latest commit | 160ccb4862ecb540b5eaad28bded92b8c866fb03 |
| Latest deploy log | https://app.netlify.com/projects/v11-carbon-web-components/deploys/684bf906d7d81d00080b9976 |
| Deploy Preview | https://deploy-preview-18464--v11-carbon-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Deploy Preview for carbon-elements ready!
| Name | Link |
|---|---|
| Latest commit | 40fcdf73734239e7b83bc26c7d508cba83c9e4cc |
| Latest deploy log | https://app.netlify.com/sites/carbon-elements/deploys/67ebc21c96b98a00084903bf |
| Deploy Preview | https://deploy-preview-18464--carbon-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 160ccb4862ecb540b5eaad28bded92b8c866fb03 |
| Latest deploy log | https://app.netlify.com/projects/v11-carbon-react/deploys/684bf906a40c8b0008a42e5c |
| Deploy Preview | https://deploy-preview-18464--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.69%. Comparing base (
220b3aa) to head (160ccb4). Report is 158 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #18464 +/- ##
==========================================
- Coverage 84.87% 84.69% -0.19%
==========================================
Files 372 373 +1
Lines 14430 14710 +280
Branches 4750 4795 +45
==========================================
+ Hits 12247 12458 +211
- Misses 2036 2102 +66
- Partials 147 150 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Hey @sangeethababu9223 any updates for this PR?
Hey @annawen1 & @guidari,
I've only worked on two handle slider and two handle skelton options. The other parity checks are remaining.
Do you think it'd be safer for me to remove playground and controls now?
Hi @sangeethababu9223
should we add other two variants in W|C to match react storybook (parity) in this PR too?
- slider--two-handle-slider
- two-handle-slider-with-hidden-inputs
Hi @sangeethababu9223
should we add other two variants in W|C to match react storybook (parity) in this PR too?
- slider--two-handle-slider
- two-handle-slider-with-hidden-inputs
Hey @2nikhiltom , There is separate PR for this.
@sangeethababu9223 are you able to take another look at this? the position of the slider thumb looks off
@sangeethababu9223 are you able to take another look at this? the position of the slider thumb looks off
Hey @annawen1, This is fixed. Please check. Thanks
should we add other two variants in W|C to match react storybook (parity) in this PR too?