carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat(slider): resolve parity issue two handle skeleton

Open sangeethababu9223 opened this issue 10 months ago • 10 comments

Closes #18473

The two handle skelton feature, available in React but missing in Web Components, is being added to Web Components.

Changelog

New

  • The two handle skelton feature has been added.
  • Style issue with existing skelton feature is fixed.

Testing / Reviewing

Go to Slider stories in storybook and it should have a working Two handle skelton story under it.

sangeethababu9223 avatar Jan 29 '25 10:01 sangeethababu9223

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit 160ccb4862ecb540b5eaad28bded92b8c866fb03
Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/684bf906d7d81d00080b9976
Deploy Preview https://deploy-preview-18464--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jan 29 '25 10:01 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 40fcdf73734239e7b83bc26c7d508cba83c9e4cc
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67ebc21c96b98a00084903bf
Deploy Preview https://deploy-preview-18464--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 29 '25 10:01 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 160ccb4862ecb540b5eaad28bded92b8c866fb03
Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/684bf906a40c8b0008a42e5c
Deploy Preview https://deploy-preview-18464--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jan 29 '25 10:01 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.69%. Comparing base (220b3aa) to head (160ccb4). Report is 158 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18464      +/-   ##
==========================================
- Coverage   84.87%   84.69%   -0.19%     
==========================================
  Files         372      373       +1     
  Lines       14430    14710     +280     
  Branches     4750     4795      +45     
==========================================
+ Hits        12247    12458     +211     
- Misses       2036     2102      +66     
- Partials      147      150       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 29 '25 11:01 codecov[bot]

Hey @sangeethababu9223 any updates for this PR?

annawen1 avatar Mar 03 '25 14:03 annawen1

Hey @annawen1 & @guidari, I've only worked on two handle slider and two handle skelton options. The other parity checks are remaining. Do you think it'd be safer for me to remove playground and controls now?

sangeethababu9223 avatar Mar 10 '25 06:03 sangeethababu9223

Hi @sangeethababu9223 image should we add other two variants in W|C to match react storybook (parity) in this PR too?

  • slider--two-handle-slider
  • two-handle-slider-with-hidden-inputs

2nikhiltom avatar Apr 14 '25 07:04 2nikhiltom

Hi @sangeethababu9223 image should we add other two variants in W|C to match react storybook (parity) in this PR too?

  • slider--two-handle-slider
  • two-handle-slider-with-hidden-inputs

Hey @2nikhiltom , There is separate PR for this.

sangeethababu9223 avatar Apr 16 '25 09:04 sangeethababu9223

@sangeethababu9223 are you able to take another look at this? the position of the slider thumb looks off

Screenshot 2025-05-20 at 12 59 06 PM

annawen1 avatar May 20 '25 17:05 annawen1

@sangeethababu9223 are you able to take another look at this? the position of the slider thumb looks off

Screenshot 2025-05-20 at 12 59 06 PM

Hey @annawen1, This is fixed. Please check. Thanks

sangeethababu9223 avatar Jun 13 '25 10:06 sangeethababu9223