carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Update Menu.mdx

Open tomlyn opened this issue 1 year ago • 7 comments

I added the open attribute to each of the <Menu> objects because the sample code will not display anything without that.

I also added a closing slash to these entries in one of the sample

<MenuItem label="Image">
<MenuItem label="Movie">
 <MenuItem label="Text">

because they are syntactically incorrect without the closing /.

Closes #

{{short description}}

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

tomlyn avatar Oct 17 '24 19:10 tomlyn

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

github-actions[bot] avatar Oct 17 '24 19:10 github-actions[bot]

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit 114a69c47e33b985ed123952eb18b4d4229a082e
Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671335e7dbc6e8000838c282
Deploy Preview https://deploy-preview-17787--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 19:10 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 114a69c47e33b985ed123952eb18b4d4229a082e
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671335e73cf3cd0009c8c31a
Deploy Preview https://deploy-preview-17787--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 19:10 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 114a69c47e33b985ed123952eb18b4d4229a082e
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671335e7dc4c84000876c231
Deploy Preview https://deploy-preview-17787--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 17 '24 19:10 netlify[bot]

thanks @tomlyn ! can you sign the DCO: https://github.com/carbon-design-system/carbon/pull/17787#issuecomment-2420334843

ariellalgilmore avatar Oct 18 '24 16:10 ariellalgilmore

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.86%. Comparing base (c1c8a8b) to head (114a69c). Report is 162 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17787   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files         406      406           
  Lines       14012    14012           
  Branches     4333     4353   +20     
=======================================
  Hits        11190    11190           
+ Misses       2657     2656    -1     
- Partials      165      166    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 18 '24 16:10 codecov[bot]

I have read the DCO document and I hereby sign the DCO.

tomlyn avatar Oct 19 '24 04:10 tomlyn

@tomlyn Thanks! Hm, this change sort of makes it seem like open is the default state, even though it isn't. Since the component API lists all available props, I wonder if open is actually needed in the examples? @tay1orjones what do you think?

kennylam avatar Oct 22 '24 01:10 kennylam

@kennylam I couldn't get the sample code to work until I added the 'open' prop. I thought it would be useful to have code that can be copied and pasted and will show something without the need for the code to be altered.

tomlyn avatar Oct 22 '24 17:10 tomlyn

Also wow this is from October 🤯 so sorry this slipped through my notifications!

tay1orjones avatar Dec 03 '24 21:12 tay1orjones

Hey there! v11.72.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Dec 05 '24 17:12 carbon-automation[bot]