carbon
carbon copied to clipboard
fix: pagination nav adjacent double ellipses
Closes #17628
Fix pagination nav adjacent ellipses
Changelog
New
- Added logic and test case for page ===0
Testing / Reviewing
Render with props itemsShown = 4, totalItems = something >= 10 Select a page from the ellipses Select the first page There should not be adjacent elleipses
Deploy Preview for v11-carbon-web-components ready!
| Name | Link |
|---|---|
| Latest commit | 2c16742469fdc955cd2eccb3654c49fa7c55b214 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-web-components/deploys/671632cb87829100088e17b2 |
| Deploy Preview | https://deploy-preview-17779--v11-carbon-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for carbon-elements ready!
| Name | Link |
|---|---|
| Latest commit | 2c16742469fdc955cd2eccb3654c49fa7c55b214 |
| Latest deploy log | https://app.netlify.com/sites/carbon-elements/deploys/671632cbdf746a000843d882 |
| Deploy Preview | https://deploy-preview-17779--carbon-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 4345adb1427ca0a4b9ed9a11593bb5cbc993dce3 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-react/deploys/6710fc2e5701d20008636b01 |
| Deploy Preview | https://deploy-preview-17779--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.93%. Comparing base (
c1c8a8b) to head (2c16742).
Additional details and impacted files
@@ Coverage Diff @@
## main #17779 +/- ##
==========================================
+ Coverage 79.86% 79.93% +0.07%
==========================================
Files 406 406
Lines 14012 14012
Branches 4333 4381 +48
==========================================
+ Hits 11190 11200 +10
+ Misses 2657 2647 -10
Partials 165 165
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 2c16742469fdc955cd2eccb3654c49fa7c55b214 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-react/deploys/671632cb3196020008a071ce |
| Deploy Preview | https://deploy-preview-17779--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey @riddhybansal I pull down locally to check the test. It is passing regarding it has the fix or not.
I guess the best way to test that is to replicate the behaviour we did together while testing the fix.
- Click on
PaginationOverflowto page 6. - Click on the first
PaginationOverflowto page 1 - Check if the page 2 is visible, which means the first
PaginationOverflowis not being rendered as expected
I'm happy to pair on that if needed.
Hey @riddhybansal I pull down locally to check the test. It is passing regarding it has the fix or not.
I guess the best way to test that is to replicate the behaviour we did together while testing the fix.
- Click on
PaginationOverflowto page 6.- Click on the first
PaginationOverflowto page 1- Check if the page 2 is visible, which means the first
PaginationOverflowis not being rendered as expectedI'm happy to pair on that if needed.
Yeah , Got what you are saying .. Added the test case for more clear testing !! This is indirectly testing the overflow menu behaviour in the pagination nav also. Please check and do let me know !!