carbon icon indicating copy to clipboard operation
carbon copied to clipboard

fix: added readonly states for fluid components

Open riddhybansal opened this issue 1 year ago • 5 comments

Closes #16939

Added readonly states to fluid components

Changelog

New

  • Added readonly states to fluid components. For FluidMultiselect , FluidDropdown, and FluidCombobox it got added automatically while converting into typescript because of their extending interfaces. If you cant see readonly state for fluid dropdown , it might be because this PR is not merged, but you can verify it in the deploy preview.

Testing / Reviewing

Test readonly state for fluid components.

riddhybansal avatar Oct 15 '24 09:10 riddhybansal

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 69036da0cffc595920abf6d1d0109b473e6872c8
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673b608ece1e7d000716318a
Deploy Preview https://deploy-preview-17746--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 15 '24 09:10 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 69036da0cffc595920abf6d1d0109b473e6872c8
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673b608e84e26c0008dcbb4a
Deploy Preview https://deploy-preview-17746--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 15 '24 09:10 netlify[bot]

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (5cf7bff) to head (e41826e). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...src/components/FluidTimePicker/FluidTimePicker.tsx 75.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17746      +/-   ##
==========================================
+ Coverage   82.10%   82.18%   +0.08%     
==========================================
  Files         404      404              
  Lines       14107    14155      +48     
  Branches     4426     4467      +41     
==========================================
+ Hits        11582    11633      +51     
+ Misses       2363     2360       -3     
  Partials      162      162              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 16 '24 10:10 codecov[bot]

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit 69036da0cffc595920abf6d1d0109b473e6872c8
Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673b608efed2760009fcc4a5
Deploy Preview https://deploy-preview-17746--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 16 '24 17:10 netlify[bot]

Hey Riddhi, Thanks for the changes. It looks like still on some components readonly is not working. I found few of them like:

  1. FluidDatePicker
  2. FluidTimePicker

can you please check.

Hey Preeti, its fixed !! Thanks for pointing out!!

riddhybansal avatar Oct 16 '24 17:10 riddhybansal

@thyhmdo this is ready for a visual review

alisonjoseph avatar Nov 14 '24 13:11 alisonjoseph

Looks good! If it's not too much trouble, can we also fix this description for Combobox?

To "Whether or not the component is read-only" – This seems to be consistent with other Fluid component's read-only description,

image

thyhmdo avatar Nov 14 '24 17:11 thyhmdo

Hey there! v11.71.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Nov 20 '24 21:11 carbon-automation[bot]