carbon icon indicating copy to clipboard operation
carbon copied to clipboard

chore(AI Label): web components - rename Slug to AI Label

Open annawen1 opened this issue 1 year ago • 5 comments

Closes #17697

This PR renames the slug component to ai-label in the web-components package and brings it out of experimental.

Changelog

Changed

  • Moved the AI Label Data Table + Example stories into their own component stories (each component has their own With AI Label story) for:
    • data-table
    • checkbox
    • combobox
    • date-picker
    • dropdown
    • modal
    • multiselect
    • number-input
    • radio-button
    • select
    • tag
    • text-input
    • textarea
    • tile
  • Renamed all instances of slug and related properties to ai-label
  • set AI Label component within the stable "Components" section of storybook

Removed

  • consolidated AI Slug / Label stories

Testing / Reviewing

View the new separate With AI Label stories for each of the components listed above in the deploy preview

annawen1 avatar Oct 14 '24 18:10 annawen1

Deploy Preview for carbon-elements ready!

Name Link
Latest commit c37c2a6f982b9c6d369e296ad3889d3a3c241045
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6717fd411623560008f2540c
Deploy Preview https://deploy-preview-17739--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 14 '24 18:10 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Name Link
Latest commit c37c2a6f982b9c6d369e296ad3889d3a3c241045
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6717fd41dcfd9f000863f33b
Deploy Preview https://deploy-preview-17739--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 14 '24 18:10 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.14%. Comparing base (7115f33) to head (c37c2a6). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17739   +/-   ##
=======================================
  Coverage   80.14%   80.14%           
=======================================
  Files         406      406           
  Lines       14029    14029           
  Branches     4391     4363   -28     
=======================================
  Hits        11243    11243           
+ Misses       2620     2619    -1     
- Partials      166      167    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 14 '24 18:10 codecov[bot]

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit c37c2a6f982b9c6d369e296ad3889d3a3c241045
Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6717fd4120300f000884f74f
Deploy Preview https://deploy-preview-17739--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 16 '24 20:10 netlify[bot]

This LGTM.

One question, will this break things for anyone currently using the Slug? I know in React we kept the slug export with the rename/move to stable, but wasn't sure if there was a similar way to do that in web components.

Oh hmm yeah it would break for folks, I was assuming since it was in experimental we would be able to rename without worrying about it being a breaking change. We could keep Slug around as its own component and I add a check to the components that can have the AI Label to see if they're using cds-slug or cds-ai-label

annawen1 avatar Oct 18 '24 15:10 annawen1

Hey there! v11.69.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Oct 24 '24 16:10 carbon-automation[bot]