refactor: rename .js to .tsx
Closes https://github.com/carbon-design-system/carbon/issues/17677
{{short description}}
Changelog
New
- {{new thing}}
Changed
- {{change thing}}
Removed
- {{removed thing}}
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
Deploy Preview for carbon-elements ready!
| Name | Link |
|---|---|
| Latest commit | e3b4912c63293b18bdf37650c6c9bf9371b54590 |
| Latest deploy log | https://app.netlify.com/sites/carbon-elements/deploys/6734be215499b100080f0718 |
| Deploy Preview | https://deploy-preview-17729--carbon-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for v11-carbon-web-components ready!
| Name | Link |
|---|---|
| Latest commit | e3b4912c63293b18bdf37650c6c9bf9371b54590 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-web-components/deploys/6734be2103f3040008346b17 |
| Deploy Preview | https://deploy-preview-17729--v11-carbon-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | e3b4912c63293b18bdf37650c6c9bf9371b54590 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-react/deploys/6734be213651f00008382c60 |
| Deploy Preview | https://deploy-preview-17729--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
Project coverage is 82.09%. Comparing base (
5cf7bff) to head (e3b4912). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #17729 +/- ##
==========================================
- Coverage 82.10% 82.09% -0.01%
==========================================
Files 404 404
Lines 14107 14117 +10
Branches 4426 4434 +8
==========================================
+ Hits 11582 11590 +8
- Misses 2363 2364 +1
- Partials 162 163 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am curious why ariaLabel is marked both deprecated and required
It was required before it was deprecated. We can't make it's replacement (aria-label) required because that's a breaking change. We could make ariaLabel optional without a breaking change, but then it would be possible for the consumer to put the component into a non-accessible state without an aria label. To get around that we could add a dev warning if neither is provided.