carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat(ai-label): add ts types

Open ariellalgilmore opened this issue 1 year ago • 5 comments

Closes #17232

Add typescript types to AI-label

Changelog

Changed

  • Converted AILabel file from JS to TSX.
  • updated align to copy Popover syntax with deprecated values

Testing / Reviewing

functionality stay the same checks still passing storybook looks good

ariellalgilmore avatar Aug 28 '24 15:08 ariellalgilmore

When checking the blame history in github you can still see the history even though it shows it as a new file

Screenshot 2024-08-28 at 8 21 25 AM

ariellalgilmore avatar Aug 28 '24 15:08 ariellalgilmore

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit d296b91040df2b874c6e74da6c9bb73d3e9caf23
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66cf405fece17c0008affa2f
Deploy Preview https://deploy-preview-17295--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 15:08 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit d296b91040df2b874c6e74da6c9bb73d3e9caf23
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66cf405f45dc3800083468e5
Deploy Preview https://deploy-preview-17295--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 15:08 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 43d30702a144e161eb247bb49edbb58882d219d0
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e1ba2b0fd73a00086be07e
Deploy Preview https://deploy-preview-17295--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 15:08 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 43d30702a144e161eb247bb49edbb58882d219d0
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e1ba2bd88c0c0008008527
Deploy Preview https://deploy-preview-17295--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 28 '24 15:08 netlify[bot]

Codecov Report

Attention: Patch coverage is 72.91667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 76.83%. Comparing base (28032c3) to head (43d3070).

Files with missing lines Patch % Lines
packages/react/src/components/AILabel/index.tsx 72.91% 13 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17295      +/-   ##
==========================================
- Coverage   76.83%   76.83%   -0.01%     
==========================================
  Files         408      408              
  Lines       13945    13949       +4     
  Branches     4323     4276      -47     
==========================================
+ Hits        10715    10718       +3     
- Misses       3056     3058       +2     
+ Partials      174      173       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 11 '24 15:09 codecov[bot]

Hey there! v11.66.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Sep 13 '24 16:09 carbon-automation[bot]