carbon icon indicating copy to clipboard operation
carbon copied to clipboard

chore: setup utilities package

Open janhassel opened this issue 1 year ago • 2 comments

Ref #16243

Changelog

New

  • Set up new package: @carbon/utilities

janhassel avatar Aug 27 '24 14:08 janhassel

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 9d3f71b4026368aecda477e41edfb896bc084fad
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ee7ee6868a650008de8c72
Deploy Preview https://deploy-preview-17280--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 27 '24 14:08 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 9d3f71b4026368aecda477e41edfb896bc084fad
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ee7ee678ae0f00088bf241
Deploy Preview https://deploy-preview-17280--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 27 '24 14:08 netlify[bot]

@mattrosno

I guess we can wait to see if we're capturing function arguments and if so, we can allowlist values like "long", "short", "narrow", etc.

Will this actually work since these string values are passed as part of an object?

janhassel avatar Sep 02 '24 06:09 janhassel

Will this actually work since these string values are passed as part of an object?

@janhassel unfortunately no, as we only capture booleans, numbers, and allowed strings. We didn't have a secure way to capture object values.

mattrosno avatar Sep 03 '24 13:09 mattrosno

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.03%. Comparing base (1ad4256) to head (9d3f71b). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17280   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files         408      408           
  Lines       13979    13979           
  Branches     4339     4339           
=======================================
  Hits        10769    10769           
  Misses       3037     3037           
  Partials      173      173           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 16 '24 20:09 codecov[bot]