refactor(17034): deprecate alternative status in notifications
Closes https://github.com/carbon-design-system/carbon/issues/17034
This PR deprecates warning-alt and info-square alternative status so we can ensure consumers know to stop using them.
NOTE :
warning-alt and info-square are used across all types of notifications
- ActionableNotification
- InlineNotification
- StaticNotification
I have deprecated this for all, let me know if this is only required on InlineNotification
Changelog
New
uses deprecateValuesWithin() to pop a warning in console when a deprecated value is used
Changed
Snapshot updated
Testing / Reviewing
Pass any desecrated value and verify that console warns about deprecated usage (I have updated in storybook examples with desecrated values to help verify this quick , just visit notification component and verify the margin present in console ) story book changes will be removed before merging
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 0947026d649ccb82671eeaf7028e84f0830ed9f3 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-react/deploys/66a9f380296a280008d3d995 |
| Deploy Preview | https://deploy-preview-17042--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for carbon-elements ready!
| Name | Link |
|---|---|
| Latest commit | 0947026d649ccb82671eeaf7028e84f0830ed9f3 |
| Latest deploy log | https://app.netlify.com/sites/carbon-elements/deploys/66a9f380a91ba00008911dea |
| Deploy Preview | https://deploy-preview-17042--carbon-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
This looks good, one question, can we bring back the dropdown control for the kind prop on the playground story?
Hey @alisonjoseph !
Yes, updated Playground.argTypes to include the dropdown control for the kind prop on the playground stories
Hey ! As discussed with Thy this is currently on hold as design team may have to consider those icons again
hi @2nikhiltom turns out that we're not deprecating these icons so I think we can just close this issue without resolving it for now. Thanks for the patience!