carbon icon indicating copy to clipboard operation
carbon copied to clipboard

refactor(17034): deprecate alternative status in notifications

Open 2nikhiltom opened this issue 1 year ago • 6 comments

Closes https://github.com/carbon-design-system/carbon/issues/17034

This PR deprecates warning-alt and info-square alternative status so we can ensure consumers know to stop using them.

NOTE :

warning-alt and info-square are used across all types of notifications

  1. ActionableNotification
  2. InlineNotification
  3. StaticNotification

I have deprecated this for all, let me know if this is only required on InlineNotification

Changelog

New

uses deprecateValuesWithin() to pop a warning in console when a deprecated value is used

Changed

Snapshot updated

Testing / Reviewing

Pass any desecrated value and verify that console warns about deprecated usage (I have updated in storybook examples with desecrated values to help verify this quick , just visit notification component and verify the margin present in console ) story book changes will be removed before merging

2nikhiltom avatar Jul 25 '24 10:07 2nikhiltom

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 0947026d649ccb82671eeaf7028e84f0830ed9f3
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66a9f380296a280008d3d995
Deploy Preview https://deploy-preview-17042--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 25 '24 10:07 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 0947026d649ccb82671eeaf7028e84f0830ed9f3
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66a9f380a91ba00008911dea
Deploy Preview https://deploy-preview-17042--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 25 '24 10:07 netlify[bot]

This looks good, one question, can we bring back the dropdown control for the kind prop on the playground story?

alisonjoseph avatar Jul 26 '24 14:07 alisonjoseph

Hey @alisonjoseph ! Yes, updated Playground.argTypes to include the dropdown control for the kind prop on the playground stories

2nikhiltom avatar Jul 31 '24 08:07 2nikhiltom

Hey ! As discussed with Thy this is currently on hold as design team may have to consider those icons again

2nikhiltom avatar Aug 02 '24 09:08 2nikhiltom

hi @2nikhiltom turns out that we're not deprecating these icons so I think we can just close this issue without resolving it for now. Thanks for the patience!

thyhmdo avatar Aug 28 '24 15:08 thyhmdo