carbon icon indicating copy to clipboard operation
carbon copied to clipboard

fix: handled 0 total items in pagination

Open riddhybansal opened this issue 1 year ago • 4 comments

Closes #16625

Handled 0 total items in pagination

Changelog

Changed

  • Added condition for 0 total items and added test case for the same.

Testing / Reviewing

Go to pagination -> Go to playground -> Set totalItems as 0 Pagination should display 0-0 of 0 items not any other numbers and 1 of 1 page not NaN pages.

riddhybansal avatar Jun 27 '24 10:06 riddhybansal

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit b5b28d1571503f49b2ca823c3d5f7fbade2c109c
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667d44915ef83c00084ba571
Deploy Preview https://deploy-preview-16876--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 27 '24 10:06 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit b5b28d1571503f49b2ca823c3d5f7fbade2c109c
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667d4491592a5b00081a3306
Deploy Preview https://deploy-preview-16876--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 27 '24 10:06 netlify[bot]

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 0bdd499304b5601104614cc6e3a65e62b30e1a13
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/667d449b8cf75e00089f9582
Deploy Preview https://deploy-preview-16876--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 27 '24 11:06 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 0bdd499304b5601104614cc6e3a65e62b30e1a13
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/667d449bf9ae2c0008132d24
Deploy Preview https://deploy-preview-16876--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 27 '24 11:06 netlify[bot]

LGTM! Thanks for adding the test

alisonjoseph avatar Jul 01 '24 13:07 alisonjoseph