carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Removed highlight from Dropdown components

Open guidari opened this issue 1 year ago • 4 comments
trafficstars

Closes #16512

Removed the selection from first items after the Dropdown is open. Changed tests to match the expected behaivour.

Testing / Reviewing

  • Test if Combobox, MultiSelect and FilterableMultiselect are not focusing on the first element.

guidari avatar Jun 14 '24 19:06 guidari

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 22e5a448c5f05e40fdab3dc955e5dffdc89ae3b5
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66ac8d791d61f9000949a404
Deploy Preview https://deploy-preview-16789--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 14 '24 19:06 netlify[bot]

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 22e5a448c5f05e40fdab3dc955e5dffdc89ae3b5
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66ac8d79c4c04a000876ee8c
Deploy Preview https://deploy-preview-16789--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 14 '24 19:06 netlify[bot]

@preetibansalui Fixed the arrow click

guidari avatar Jun 19 '24 17:06 guidari

Thanks @guidari for the changes, Its looking perfect. Just want to confirm one minor thing that I notice in multiselect. If we select something in multiselect and reopen this, It won't have any item as highlighted while for filterable, dropdown and combobox on reopen they have highlighted options. @Kritvi-bhatia17 Can you please confirm if this behaviour is correct? Attaching video for reference.

https://github.com/carbon-design-system/carbon/assets/146315451/82deeded-e3db-46b6-be4e-ab71b73acbc3

preetibansalui avatar Jun 20 '24 08:06 preetibansalui

Although this is not related to this issue, when I click on multi-select, the component appears in the middle instead of the top left like all other components. Any idea why this bug is occurring?

Screenshot 2024-07-13 at 2 09 50 PM

Kritvi-bhatia17 avatar Jul 13 '24 08:07 Kritvi-bhatia17

Fixed the issues @Kritvi-bhatia17

Although this is not related to this issue, when I click on multi-select, the component appears in the middle instead of the top left like all other components. Any idea why this bug is occurring?

It is only for testing purpouse. So the user can test the Floating UI when the autoAlign is set to true

guidari avatar Jul 15 '24 19:07 guidari

Sorry, I came late to this issue. Just wanted to ask if this is correct for the Invalid and Warning states.

image

thyhmdo avatar Jul 24 '24 19:07 thyhmdo