carbon
carbon copied to clipboard
Removed highlight from Dropdown components
Closes #16512
Removed the selection from first items after the Dropdown is open. Changed tests to match the expected behaivour.
Testing / Reviewing
- Test if
Combobox,MultiSelectandFilterableMultiselectare not focusing on the first element.
Deploy Preview for v11-carbon-react ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 22e5a448c5f05e40fdab3dc955e5dffdc89ae3b5 |
| Latest deploy log | https://app.netlify.com/sites/v11-carbon-react/deploys/66ac8d791d61f9000949a404 |
| Deploy Preview | https://deploy-preview-16789--v11-carbon-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for carbon-elements ready!
| Name | Link |
|---|---|
| Latest commit | 22e5a448c5f05e40fdab3dc955e5dffdc89ae3b5 |
| Latest deploy log | https://app.netlify.com/sites/carbon-elements/deploys/66ac8d79c4c04a000876ee8c |
| Deploy Preview | https://deploy-preview-16789--carbon-elements.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@preetibansalui Fixed the arrow click
Thanks @guidari for the changes, Its looking perfect. Just want to confirm one minor thing that I notice in multiselect. If we select something in multiselect and reopen this, It won't have any item as highlighted while for filterable, dropdown and combobox on reopen they have highlighted options. @Kritvi-bhatia17 Can you please confirm if this behaviour is correct? Attaching video for reference.
https://github.com/carbon-design-system/carbon/assets/146315451/82deeded-e3db-46b6-be4e-ab71b73acbc3
Although this is not related to this issue, when I click on multi-select, the component appears in the middle instead of the top left like all other components. Any idea why this bug is occurring?
Fixed the issues @Kritvi-bhatia17
Although this is not related to this issue, when I click on multi-select, the component appears in the middle instead of the top left like all other components. Any idea why this bug is occurring?
It is only for testing purpouse. So the user can test the Floating UI when the autoAlign is set to true
Sorry, I came late to this issue. Just wanted to ask if this is correct for the Invalid and Warning states.