carbon icon indicating copy to clipboard operation
carbon copied to clipboard

[Link] Adding an underline on the focus state and active state

Open thyhmdo opened this issue 1 year ago • 3 comments

Ref issue: https://github.com/carbon-design-system/carbon-website/issues/3537

PROBLEM The focus state of the Standalone Link needs to have an underline. There's only padding to differentiate it from the focus state of the Ghost button.

Standalone link (default and focus state)

image image

Ghost button

image image

INCONSISTENCY Active state: When you hold the click over the inline link, there's no underline. But when you hold the click on the Standalone link, there's an underline


SOLUTION

  • [x] Need to add design specs here - Need a review from @laurenmrice

4_3_608x456px

thyhmdo avatar Jan 26 '24 17:01 thyhmdo

Specs provided for devs

Link specs

thyhmdo avatar Feb 08 '24 17:02 thyhmdo

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

github-actions[bot] avatar Feb 08 '24 22:02 github-actions[bot]

It would be interesting to try and see if we could VRT these changes so that we have a snapshot for each state of both standalone and inline.

We could augment the VRT tests to use the keyboard to navigate and get the links into the various states (active, hover, etc) and then do a percy snapshot for each of those.

tay1orjones avatar Feb 22 '24 15:02 tay1orjones