carbon icon indicating copy to clipboard operation
carbon copied to clipboard

feat: add types to Copy and CopyButton

Open Tresau opened this issue 1 year ago • 3 comments

Closes #13551 Closes #13227

Add TypeScript types for Copy and CopyButton

Changelog

New

  • Types for Copy and CopyButton

Changed

  • .js -> .tsx file extensions for Copy and CopyButton

Removed

  • n/a

Testing / Reviewing

Verify that the unit tests run and pass. Verify that the Storybook for CopyButton works as intended.

Tresau avatar Nov 15 '23 16:11 Tresau

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 944e3c830cf91b8b22a57a441a10703f9717529a
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f050803490f6000865f3ca
Deploy Preview https://deploy-preview-15213--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Nov 15 '23 16:11 netlify[bot]

@Tresau-IBM now that the types for IconButton have been merged (https://github.com/carbon-design-system/carbon/pull/15057) has been merged, can this be updated?

tw15egan avatar Feb 05 '24 18:02 tw15egan

@Tresau-IBM now that the types for IconButton have been merged (#15057) has been merged, can this be updated?

sorry for the delay, was unavailable, will update this shortly :)

Tresau avatar Feb 13 '24 19:02 Tresau

@Tresau-IBM are you able to resolve the conflicts? Thank you!

andreancardona avatar Feb 26 '24 18:02 andreancardona

@tw15egan @andreancardona, the conflicts have been resolved and the workaround for IconButton has been removed.

Tresau avatar Mar 07 '24 15:03 Tresau

Hey there! v11.53.0 was just released that references this issue/PR.

carbon-automation[bot] avatar Mar 13 '24 17:03 carbon-automation[bot]