carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

React notice choice - Add China PIPL content

Open sanjitbauli opened this issue 2 years ago • 6 comments

Related Ticket(s)

https://jsw.ibm.com/browse/URX-402

Description

As per the new Chinese PIPL requirement, an additional text need to be shown to the user along with IBM's privacy statement. Applicable for the English language with the user's provided country China. For the Chinese language, the main content is updated and no changes are required in this component.

Changed

Existing: Screenshot 2022-10-20 at 3 42 18 PM Replaced with: Screenshot 2022-10-20 at 3 40 16 PM

Removed

  • {{removed thing}}

sanjitbauli avatar Oct 20 '22 10:10 sanjitbauli

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
:white_check_mark: @sanjitbauli
:x: @kennylam
kennylam seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Oct 20 '22 10:10 github-actions[bot]

Deploy preview created for package React: https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9581/index.html

Built with commit: 2be95d5036530a325d60534f290b1623fd5cfb33

ibmdotcom-bot avatar Oct 20 '22 10:10 ibmdotcom-bot

Deploy preview created for package NextJS Test Application: https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9581/index.html

Built with commit: 2be95d5036530a325d60534f290b1623fd5cfb33

ibmdotcom-bot avatar Oct 20 '22 10:10 ibmdotcom-bot

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9581/index.html

Built with commit: 2be95d5036530a325d60534f290b1623fd5cfb33

ibmdotcom-bot avatar Oct 20 '22 10:10 ibmdotcom-bot

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9581/index.html

Built with commit: 2be95d5036530a325d60534f290b1623fd5cfb33

ibmdotcom-bot avatar Oct 20 '22 10:10 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9581/index.html

Built with commit: 2be95d5036530a325d60534f290b1623fd5cfb33

ibmdotcom-bot avatar Oct 20 '22 11:10 ibmdotcom-bot

@sanjitbauli it might be easier if you want to make a clean commit from the main branch, so that we aren't blocked by the DCO assistant agreenment

ariellalgilmore avatar Oct 24 '22 15:10 ariellalgilmore

Another PR with a clean commit was created. https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/9606 Closing this.

sanjitbauli avatar Oct 31 '22 11:10 sanjitbauli