carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

fix(storybook): improve feature flags granularity

Open jkaeser opened this issue 2 years ago • 7 comments

Related Ticket(s)

none

Description

The way experimental components' feature flags work was changed at some point after updating Storybook. The current behavior is an all-or-nothing approach where the presence of any feature flag as an environment variable reveals every experimental component.

This PR restores the ability to hide specific components by iteratively building up the CSS that hides components from the sidebar list.

Changelog

Changed

  • Restores ability to selectively hide/show individual experimental components in Storybook.

jkaeser avatar Oct 17 '22 17:10 jkaeser

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 17 '22 18:10 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 17 '22 18:10 ibmdotcom-bot

Deploy preview created for package React: https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 17 '22 18:10 ibmdotcom-bot

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 17 '22 18:10 ibmdotcom-bot

Deploy preview created for package NextJS Test Application: https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 17 '22 19:10 ibmdotcom-bot

Deploy preview created for package "React (experimental)": https://ibmdotcom-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: 234f7a4a93eda451b443435c33b165392fffebe9

ibmdotcom-bot avatar Oct 18 '22 20:10 ibmdotcom-bot

Deploy preview created for package "Web Components (experimental)": https://ibmdotcom-web-components-experimental.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9568/index.html

Built with commit: a2375e863b0498f698e7023c6f10b44165eafa42

ibmdotcom-bot avatar Oct 21 '22 15:10 ibmdotcom-bot

LGTM! Thanks for this update. @jkaeser would you possibly want to make the same changes for the react package?

Sure can, @ariellalgilmore! I'll add that soon.

jkaeser avatar Oct 24 '22 15:10 jkaeser