carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

fix(masthead): pass logo data from endpoint json to composite (#9462)

Open jkaeser opened this issue 2 years ago • 10 comments

Related Ticket(s)

Resolves #9462

Description

Adds support for a new logo key in the masthead translation data schema so that JSON files from the dataEndpoint can modify certain logo attributes such as the href value.

Changelog

New

  • Adds support for modifying masthead logo from the dataEndpoint JSON files.

jkaeser avatar Oct 06 '22 15:10 jkaeser

Deploy preview created for package React: https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 06 '22 15:10 ibmdotcom-bot

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 06 '22 15:10 ibmdotcom-bot

Deploy preview created for package NextJS Test Application: https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 06 '22 15:10 ibmdotcom-bot

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 06 '22 15:10 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 06 '22 16:10 ibmdotcom-bot

Deploy preview created for package "Services": https://ibmdotcom-services.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 07 '22 19:10 ibmdotcom-bot

I went back and forth for a bit thinking if we ought to add a knob for this property, but since the href isn't really author-editable and instead comes from the translation's json file, the e2e tests are probably enough.

andy-blum avatar Oct 11 '22 14:10 andy-blum

Deploy preview created for package "React (experimental)": https://ibmdotcom-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 18 '22 14:10 ibmdotcom-bot

Deploy preview created for package "Web Components (experimental)": https://ibmdotcom-web-components-experimental.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9465/index.html

Built with commit: bb24d8e187d9900e4d1b523d31930824bab6c43b

ibmdotcom-bot avatar Oct 18 '22 16:10 ibmdotcom-bot

@IgnacioBecerra @annawen1 Do you know why the Deploy Preview - Web Components - React Wrapper check is failing?

jkaeser avatar Oct 19 '22 20:10 jkaeser

Looks like the last blocker for merging is taking a look at the Percy change. Is this something you can do, @RichKummer?

jkaeser avatar Oct 26 '22 17:10 jkaeser