carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

test(profileAPI): expand test coverage to include cloud masthead

Open andy-blum opened this issue 2 years ago • 5 comments

Related Ticket(s)

Closes #9314

Description

Expands ProfileAPI unit tests to cover cloud masthead usage

Changelog

Changed

  • updated test coverage

andy-blum avatar Sep 06 '22 19:09 andy-blum

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9334/index.html

Built with commit: 211d600139e70c6cfaa9bc1e27bb5fd90a900caf

ibmdotcom-bot avatar Sep 06 '22 19:09 ibmdotcom-bot

Deploy preview created for package React: https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9334/index.html

Built with commit: 211d600139e70c6cfaa9bc1e27bb5fd90a900caf

ibmdotcom-bot avatar Sep 06 '22 19:09 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9334/index.html

Built with commit: 211d600139e70c6cfaa9bc1e27bb5fd90a900caf

ibmdotcom-bot avatar Sep 06 '22 19:09 ibmdotcom-bot

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9334/index.html

Built with commit: 211d600139e70c6cfaa9bc1e27bb5fd90a900caf

ibmdotcom-bot avatar Sep 06 '22 21:09 ibmdotcom-bot

Deploy preview created for package NextJS Test Application: https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9334/index.html

Built with commit: 211d600139e70c6cfaa9bc1e27bb5fd90a900caf

ibmdotcom-bot avatar Oct 13 '22 14:10 ibmdotcom-bot

We should also move the Cloud cookie tests from packages/services/src/services/CloudAccountAuth/__tests__/CloudAccountAuth.test.js to packages/services/src/services/Profile/__tests__/.... Not seeing any test file for Profile service, but we should at least have Cloud cookie and Docs API tests there.

annawen1 avatar Jan 11 '23 16:01 annawen1

@annawen1 @andy-blum This PR has been on the back burner for a while. Is there any work/review that we need to follow up on?

proeung avatar Apr 04 '23 20:04 proeung

Closing this PR out for now, since there's a discussion to remove Cloud Masthead within the /cloud web segment. I'll leave the original issue (https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/9314) and move it to the ice box in case we need to follow this backup if the Cloud Masthead continues to exist.

proeung avatar Apr 11 '23 18:04 proeung