carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

[Web Components | Lit] Investigate upgrade to Lit 2.x

Open jeffchew opened this issue 4 years ago • 9 comments

The problem

Blocked by https://github.com/carbon-design-system/carbon-web-components/issues/974

Carbon Web Components is currently running on v1.x of lit-element / lit-html. This is one of the fundamental libraries used for rendering web components within this repository.

The solution

Investigate the level of effort for upgrading carbon-web-components to Lit 2.x.

Additional information

  • Investigation should consider users that are currently on lit-html/lit-element, and if there is any messaging necessary to have users upgrade to lit 2.
  • Corresponding upgrade issue for carbon-web-components: https://github.com/carbon-design-system/carbon-web-components/issues/657
  • Upgrade documentation: https://lit.dev/docs/releases/upgrade/
  • Additional information regarding the update is captured in this issue.

jeffchew avatar Jun 14 '21 13:06 jeffchew

To be added to the June 28 engineering issues refinement meeting agenda.

RobertaJHahn avatar Jun 17 '21 12:06 RobertaJHahn

Will hold on this for now, investigation began with carbon-web-components and found that there is a directive that we are waiting on, more details at https://github.com/carbon-design-system/carbon-web-components/issues/657.

jeffchew avatar Aug 20 '21 13:08 jeffchew

There are any ETA to migrate carbon-web-components to Lit v2? Thanks!

abdonrd avatar Jun 09 '22 15:06 abdonrd

Any news here? It's been almost a year since Lit v2 came out. Thanks!

abdonrd avatar Jul 22 '22 09:07 abdonrd

There is a new version 2.3 that prevents errors with windows not defined while using it with SSR in Node. We are working with that versión, and it will be very useful to have it updated.

korgan00 avatar Aug 17 '22 13:08 korgan00

Has there been any progress on this? my team ran into an issue today where we are trying to access a web component built with carbon via a CDN but the import failed because the CDN requires v2 and the carbon component only has v1

javabster avatar Oct 11 '22 20:10 javabster

This is blocking some things in qiskit.org. It would be great to have bump soon :)

1ucian0 avatar Oct 12 '22 14:10 1ucian0

Hi @1ucian0 ! Right now the bump for lit 2 is slated for this quarter (Q4 2022). Note that this also is in tandem with an upgrade to Carbon v11 so this will be a major release to Carbon Web Components v2!

We will have some other announcements regarding Carbon Web Components as part of this, so stay tuned!

jeffchew avatar Oct 13 '22 12:10 jeffchew

@jeffchew more good news!

@open-wc/[email protected] just released with spread, spreadEvents, and spreadProps directives! https://github.com/open-wc/open-wc/releases/tag/%40open-wc/lit-helpers%400.5.0

abdonrd avatar Oct 18 '22 13:10 abdonrd

To update this issue a bit, it is being worked on!

  • https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/9905
  • https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/9958

abdonrd avatar Jan 31 '23 14:01 abdonrd

Another related issue:

  • https://github.com/carbon-design-system/carbon-for-ibm-dotcom/issues/9750

abdonrd avatar Feb 21 '23 21:02 abdonrd

Just want to say I appreciate so much the constant check-ins from @abdonrd, and much love to everyone on the team for all the work that has gone into building out Carbon. I'm currently using the lit alpha release and for my limited use case it's working perfectly. I haven't tried using the more complex components like data table, but it's probably better to wait a bit in case another alpha version is released.

kr05 avatar Feb 27 '23 21:02 kr05

Just want to say I appreciate so much the constant check-ins from @abdonrd, and much love to everyone on the team for all the work that has gone into building out Carbon. I'm currently using the lit alpha release and for my limited use case it's working perfectly. I haven't tried using the more complex components like data table, but it's probably better to wait a bit in case another alpha version is released.

I concur and thank you @abdonrd for staying on top of this (us!). Work is currently in flight to also upgrade Carbon Web Components to Carbon v11, which in of itself will also bring some pretty great upgrades there. From there, we should be seeing an initial v2.0.0 beta (and release candidates).

Apologies for the radio silence on this and the changing of dates, @kennylam and team will provide an updated timeline hopefully soon, but we also plan on including a sync of features between Carbon Web Components and Carbon React shortly after, so the team definitely has its work cut out for it!

cc: @annawen1 @emyarod @IgnacioBecerra @ariellalgilmore @ljcarot @jeanservaas

jeffchew avatar Feb 27 '23 22:02 jeffchew

Thanks @jeffchew!

I hope it will be soon! 🤞

abdonrd avatar Feb 28 '23 13:02 abdonrd

Related PR about the update to Carbon v11:

  • https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/10196

abdonrd avatar Mar 07 '23 20:03 abdonrd

Love to see this!! It seems alpha is finally here 👀 🎉

kr05 avatar Apr 04 '23 16:04 kr05

@jeffchew closed with the new release?

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/releases/tag/%40carbon/web-components%402.0.0

abdonrd avatar Aug 17 '23 16:08 abdonrd