carbon-for-ibm-dotcom
carbon-for-ibm-dotcom copied to clipboard
chore(button-group): clean up styles
Related Ticket(s)
Closes #11198
Description
- Breaks button-group and button-group-item styles into separate files
- Migrates component styles solely into web-components package
- Removes unnecessary style imports & rules
Changelog
Changed
- Cleans up styles of
button-groupandbutton-group-item
Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html
Built with commit: 3b7fe5272835827276127645473bf19853d75ee4
Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html
Built with commit: 3b7fe5272835827276127645473bf19853d75ee4
Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html
Built with commit: 3b7fe5272835827276127645473bf19853d75ee4
Well I'll be, I'm not seeing the missing icons anymore either. Must be ghosts. Approved!
Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html
Built with commit: 3b7fe5272835827276127645473bf19853d75ee4
Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
| Name | Link |
|---|---|
| Latest commit | 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b |
| Latest deploy log | https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/679b5aefc7ffd900081a4daf |
| Deploy Preview | https://deploy-preview-11200--ibm-dotcom-web-components-react-wrap.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for ibm-dotcom-web-components ready!
| Name | Link |
|---|---|
| Latest commit | 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b |
| Latest deploy log | https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/679b5aeff255340008b69000 |
| Deploy Preview | https://deploy-preview-11200--ibm-dotcom-web-components.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@andy-blum is this still worth adopting? When we last were talking about it, John and I were both good with it, and we were only waiting on DPO.
Deploy Preview for incomparable-wisp-8d6771 ready!
| Name | Link |
|---|---|
| Latest commit | 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b |
| Latest deploy log | https://app.netlify.com/sites/incomparable-wisp-8d6771/deploys/679b5aef9ac925000821753a |
| Deploy Preview | https://deploy-preview-11200--incomparable-wisp-8d6771.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.