carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

chore(button-group): clean up styles

Open andy-blum opened this issue 1 year ago • 5 comments

Related Ticket(s)

Closes #11198

Description

  • Breaks button-group and button-group-item styles into separate files
  • Migrates component styles solely into web-components package
  • Removes unnecessary style imports & rules

Changelog

Changed

  • Cleans up styles of button-group and button-group-item

andy-blum avatar Dec 05 '23 16:12 andy-blum

Deploy preview created for package Carbon Web Components: https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

ibmdotcom-bot avatar Dec 05 '23 16:12 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

ibmdotcom-bot avatar Dec 05 '23 19:12 ibmdotcom-bot

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

ibmdotcom-bot avatar Dec 05 '23 19:12 ibmdotcom-bot

Well I'll be, I'm not seeing the missing icons anymore either. Must be ghosts. Approved!

jkaeser avatar Jan 02 '24 21:01 jkaeser

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11200/index.html

Built with commit: 3b7fe5272835827276127645473bf19853d75ee4

ibmdotcom-bot avatar Feb 27 '24 21:02 ibmdotcom-bot

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
Latest commit 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b
Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/679b5aefc7ffd900081a4daf
Deploy Preview https://deploy-preview-11200--ibm-dotcom-web-components-react-wrap.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 11 '24 18:12 netlify[bot]

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
Latest commit 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b
Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/679b5aeff255340008b69000
Deploy Preview https://deploy-preview-11200--ibm-dotcom-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 13 '24 16:12 netlify[bot]

@andy-blum is this still worth adopting? When we last were talking about it, John and I were both good with it, and we were only waiting on DPO.

m4olivei avatar Dec 23 '24 13:12 m4olivei

Deploy Preview for incomparable-wisp-8d6771 ready!

Name Link
Latest commit 2935ec21016d6d3948f6f053ce0f2c5b743a2b5b
Latest deploy log https://app.netlify.com/sites/incomparable-wisp-8d6771/deploys/679b5aef9ac925000821753a
Deploy Preview https://deploy-preview-11200--incomparable-wisp-8d6771.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jan 30 '25 10:01 netlify[bot]