carbon-design-kit icon indicating copy to clipboard operation
carbon-design-kit copied to clipboard

[Dropdown: Combobox & Multi-select] Update Figma Kit

Open Kritvi-bhatia17 opened this issue 1 year ago • 0 comments

Before starting this issue check with dev & Michael :

For fluid styles:

  • [x] Is it correct that the fluid dropdown does not get a focus state in the field when there is also a focus state on an item in the list? Looks like we have both focus states present in fluid multi-select and for the default dropdown and multi-selects. Not sure if that is an oversight or if there is a reason why it is different.

Regarding the focus state when expanding the dropdown:

  • [x] Confirm if it is intentional for the focus state to be initially on the pre-selected item and whether it is designed to become unfocused as soon as the mouse exits the dropdown.
  • [x] Explore the behavior when there is no default selection. Confirm whether any focus state is applied to options in this scenario.

All themes Figma library

  • [x] Default Dropdown
    • [x] Single-select
    • [x] Multi-select
  • [x] Fluid Dropdown
    • [x] Single-select
    • [x] Multi-select

  • [x] Next step is to talk to Michael and other designer to decide & finalise on the dropdown's design interaction.

Michael suggestions :

Single select dropdown (both the default and fluid state) :

  • Parent component
    • No focus state when expanded
  • Child component
    • Focus state on the selected option.
    • If none selected, the first child has the focus state.
  • Persistence
    • Focus state remains as cursor moves out of the dropdown component.

Multi select dropdown (both the default and fluid state) :

  • Parent component
    • Focus state will be there when expanded as their is an interactive state within the parent's component
  • Child component
    • Focus state on the selected option.
    • If none selected, the first child has the focus state.
    • In case where multiple options are selected the focus state will be there for the first selected option
  • Persistence
    • Focus state remains as cursor moves out of the dropdown component.

Next step:

  • [x] Update the parent's and child's focus state
  • [x] Update all the inconsistencies, bugs, miss
    • [x] Remove the hover state from the Dropdown - Combo box - Default & Fluid
    • [x] Add focus and hover state in the Dropdown - Multi-select - Default & Fluid

Review

  • [x] Review (accessibility expert/Michael)
  • [x] Review (carbon designer)

image

Kritvi-bhatia17 avatar Feb 21 '24 07:02 Kritvi-bhatia17