carbon-design-kit icon indicating copy to clipboard operation
carbon-design-kit copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

[Loading]: Design kit inconsistencies, open questions

Open tay1orjones opened this issue 2 years ago • 3 comments

Surfaced in https://github.com/carbon-design-system/carbon/pull/11759#issuecomment-1183238533 by @mbgower

~### Why are inline loading and loading treated as separate components?~ ~Inline loading is a separate component from Loading on the Carbon Design System website and storybook; however in Sketch and Figma, inline loading is a variant on Loading. I think the latter makes sense, overall, and I suggest the two components be combined. If desired to keep separate, then they should be separated in the Design kit, IMO.~

Sketch vs Figma vs implementation

Note that there are some differences in how Figma and Sketch show the inline loading that should be addressed. Sketch includes inline loading on text inputs; Figma does not. Figma includes a icon-less version (which I think is the 'inactive' one); Sketch does not. Neither show the above implemented variant of a button that updates its text. I consider that almost a different variant.

tay1orjones avatar Jul 18 '22 13:07 tay1orjones

Tasks Investigate inconsistency in Figma vs. Sketch

  • Figma:

    • [x] Add input with inline loading
    • [x] Add button inline loading (active and finished states)
    • [x] Review (in progress)

  • Sketch:

    • [x] Add inactive inline loading text
    • [x] Add button inline loading (active and finished states)

Note: The documentation aspect will be addressed through the variant workstream happening on Platform.

aagonzales avatar Dec 14 '22 17:12 aagonzales

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] avatar May 16 '23 18:05 stale[bot]

@tay1orjones and @laurenmrice this has be cross-referenced a number of times in 1H. is the "inactive" label the bot warns about valid?

mbgower avatar May 16 '23 19:05 mbgower

We are no longer maintaining our Sketch libraries in favor of our Figma libraries, so we will be closing this issue.

We have a separate open issue to add inline loading in buttons for modal https://github.com/carbon-design-system/carbon-design-kit/issues/746.

laurenmrice avatar May 21 '24 23:05 laurenmrice