carbon-components-vue icon indicating copy to clipboard operation
carbon-components-vue copied to clipboard

feat: Add pagination nav component

Open mrsideshowjack opened this issue 5 years ago • 4 comments

Closes #635

adds the pagination nav component, modeled after the react implementation.

Changelog

A       packages/core/src/components/cv-pagination-nav/cv-pagination-nav-item.vue
A       packages/core/src/components/cv-pagination-nav/cv-pagination-nav-notes.md
A       packages/core/src/components/cv-pagination-nav/cv-pagination-nav-overflow.vue
A       packages/core/src/components/cv-pagination-nav/cv-pagination-nav.vue
A       packages/core/src/components/cv-pagination-nav/index.js
M       packages/core/src/index.js
A       storybook/stories/cv-pagination-nav-story.js

Note: Note the commented out code in cv-pagination-nav.vue, still working on the math on where/how to cut the list into overflow items. Any help is appreciated. Wanted to get the PR open for visibility (and before November 😂). In it's current state it will work without any overflow items.

mrsideshowjack avatar Oct 28 '20 18:10 mrsideshowjack

✔️ Deploy Preview for carbon-components-vue ready!

🔨 Explore the source changes: debab6b69604a5653dfa18c238e11609cae333cd

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6187f2f6beef410008554c42

😎 Browse the preview: https://deploy-preview-1057--carbon-components-vue.netlify.app

netlify[bot] avatar Oct 28 '20 18:10 netlify[bot]

@mrsideshowjack is there anything you need from me to progress this into 'Ready for review'?

lee-chase avatar Nov 18 '20 14:11 lee-chase

@mrsideshowjack @lee-chase I played around with this and it works fine to me.

It does seem to be missing the aria-current="page"

dubcanada avatar Jan 20 '21 14:01 dubcanada

Sort of works @dubcanada @mrsideshowjack

It does not update when the props change.

It is also missing behaviour restricting the number of items shown.

lee-chase avatar Nov 07 '21 15:11 lee-chase