carbon-components-svelte icon indicating copy to clipboard operation
carbon-components-svelte copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

Layer (new component)

Open theetrain opened this issue 1 year ago • 3 comments
trafficstars

Spun off from #1629

  • [ ] Add new Layer component. Reference: https://react.carbondesignsystem.com/?path=/docs/components-layer--overview
  • [ ] Deprecate the light prop from TextInput. Recommend using Layer component instead. To be removed in [email protected].
  • [ ] Adjust related components to ensure they work well with Layer

theetrain avatar Jan 14 '24 20:01 theetrain

I don't think the light prop should be removed in v11. The React library has it marked for removal in v12, doesn't it?

SimpleProgrammingAU avatar Jan 18 '24 08:01 SimpleProgrammingAU

You're right that the React component has it deprecated; probably to ease into its removal when Layer became available, but not because of forthcoming v12 styles. We should follow a similar backwards-compatibility cadence:

https://github.com/carbon-design-system/carbon/blob/be888a850730d9658decaf1336f4b3175eb4d817/packages/react/src/components/TextInput/TextInput.tsx#L84-L90

I updated the criteria above.

theetrain avatar Jan 20 '24 20:01 theetrain

What are the outstanding tasks following the merge of PR #1932?

SimpleProgrammingAU avatar Mar 26 '24 08:03 SimpleProgrammingAU