carbon-components-angular
carbon-components-angular copied to clipboard
feat: add useRouter property to sidenav
Closes carbon-design-system/carbon-components-angular#2811
This MR adds a useRouter
option to the SideNav component (which is false
by default).
When the input
is true
, routerLink
will be used instead.
Changelog
New
- adds
useRouter
input toSideNav
DCO Assistant Lite bot All contributors have signed the DCO.
Deploy Preview for carbon-components-angular failed.
Name | Link |
---|---|
Latest commit | 9e3ceaabc40016ea0ac9b71e9a951a29191d43d7 |
Latest deploy log | https://app.netlify.com/sites/carbon-components-angular/deploys/65f04fccc8265200098f8494 |
I have read the DCO document and I hereby sign the DCO.
Deploy Preview for carbon-components-angular ready!
Name | Link |
---|---|
Latest commit | 0cc9077b9b60055116122d93ec7a7b34957a70b8 |
Latest deploy log | https://app.netlify.com/sites/carbon-components-angular/deploys/660cfb13474a120008dc9d6e |
Deploy Preview | https://deploy-preview-2812--carbon-components-angular.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
recheck
Thanks for the review @Akshat55! Took care of your remarks.
Quick question, did you do manual linting here? If so, is there a possibility to automate some things? Like adding eslint or prettier to the repo maybe?
Quick question, did you do manual linting here? If so, is there a possibility to automate some things? Like adding eslint or prettier to the repo maybe?
We do some manual linting here and there while reviewing the code. We do have a linter (tslint) and we run it prior to pushing the commit (using husky).
We haven't updated to eslint in v5 because we noticed it was taking way too long. From what I've seen, the duration has decreased and we plan to replace our existing linter with eslint in v6!
Quick question, did you do manual linting here? If so, is there a possibility to automate some things? Like adding eslint or prettier to the repo maybe?
We do some manual linting here and there while reviewing the code. We do have a linter (tslint) and we run it prior to pushing the commit (using husky).
We haven't updated to eslint in v5 because we noticed it was taking way too long. From what I've seen, the duration has decreased and we plan to replace our existing linter with eslint in v6!
Ah right, noticed a warning in my console when pushing/committing. Prolly I should look into resolving that.
:tada: This PR is included in version 5.22.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
This PR enabled the routing by default, but didn't take in consideration the routeExtras
passed to the component (which is breaking anyone using the relativeTo
option)