[RFC] Deprecate FileDrop in favor of FileUploader

[tay1orjones]

trafficstars

Carbon recently added drop and drop file uploader components (#3872). It seems this may invalidate the need for us to have our own version of this.

We should evaluate and consider deprecating our FileDrop in favor of the Carbon component, or extending the carbon component with any additional functionality we require.

@lukefirth @scottdickerson Do you see any reason we couldn't deprecate ours?

[tay1orjones]

Worth noting the new components are available in Carbon v10.7. We could deprecate at the same time as the upgrade in #581

[tay1orjones]

@bryancboyd could you add some context here as to your thoughts on what we can/can't deprecate?

[davidicus]

this issue is tale. Closing but feel free to re-open if necessary

[tay1orjones]

I think we should reopen the conversation about deprecating FileDrop, with the aim to consolidate on the stock Carbon component, FileUploader. We have a couple open bugs on FileDrop https://github.com/carbon-design-system/carbon-addons-iot-react/issues/1178 https://github.com/carbon-design-system/carbon-addons-iot-react/issues/1453 that would be better fixed by deprecating and pointing consumers to refactoring to use FileUploader.

• [ ] Place deprecation notice on FileDrop
• [ ] Remove it in v3 (not part of this issue, but worth noting)

@dianatran18 Is there any functionality or design available in FileDrop that isn't available in FileUploader?

[sstone2423]

I don't think this would affect Monitor too much. We only use FileDrop once and it could easily be converted to use FileUploaderButton (one of the subcomponents of FileUploader) instead. Any thoughts @scottdickerson ? We only use the button like this story: https://react.carbondesignsystem.com/?path=/story/fileuploader--fileuploaderbutton

[lukefirth]

Agreed - in fact, I strongly suspect we ended up with our own due to the fact that Carbon made this available in the sketch kit a while before they made it available as a component in code, rather than us having any real desire to have our own.

(In fact - from a design kit side, we don't actually have our own version of this, we just use the Carbon one).

My vote: Deprecate away 😄

[dianasanborn]

I'm good with deprecating if it doesn't affect any teams using it. From all of the design use cases I've heard of, the Carbon FileUploader was sufficient to use

[stuckless]

FYI... Puralotor just stopped by and picked up the ceiling tiles.

On Mon, Aug 10, 2020 at 1:24 PM Diana Tran [email protected] wrote:

I'm good with deprecating if it doesn't affect any teams using it. From all of the design use cases I've heard of, the Carbon FileUploader was sufficient to use

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/carbon-design-system/carbon-addons-iot-react/issues/611#issuecomment-671484663, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIB6KJTUHVI34TCDBDMTTDSAAUMXANCNFSM4I757G7Q .