carbon-addons-iot-react
carbon-addons-iot-react copied to clipboard
fix(barchartutils): condition check for categorydatasourceid
Closes Monitor - https://github.ibm.com/wiotp/Maximo-Asset-Monitor/issues/4717
Summary
- summary_here
Change List (commits, features, bugs, etc)
- [fix(barchartutils): condition check for categorydatasourceid rather than assigning undefined
Acceptance Test (how to verify the PR)
- tests here
Regression Test (how to make sure this PR doesn't break old functionality)
- tests here
Things to look for during review
- [ ] Make sure all references to
iotorbxclass prefix is using the prefix variable - [ ] (React) All major areas have a
data-testidattribute. New test ids should have test written to ensure they are not changed or removed. - [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
- [ ] All strings should be translatable.
- [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
- [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
- [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
- [ ] Changes or new components should either write new or update existing documentation.
- [ ] PR should link and close out an existing issue
Deploy Preview for carbon-addons-iot-react ready!
| Name | Link |
|---|---|
| Latest commit | 5cdeec5b22e673a2f165523faf71f9026a7c0ce7 |
| Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/63a4165a04add60008750e28 |
| Deploy Preview | https://deploy-preview-3598--carbon-addons-iot-react.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Deploy Preview for ai-apps-pal-angular ready!
| Name | Link |
|---|---|
| Latest commit | 9613635553b9fa1353b6377aebf8b0ee5d68f2df |
| Latest deploy log | https://app.netlify.com/sites/ai-apps-pal-angular/deploys/6349104544e0e8000841fbbf |
| Deploy Preview | https://deploy-preview-3598--ai-apps-pal-angular.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Issues should outline how this bug can be reproduced in the PAL storybook if possible. The acceptance test part of this PR template should outline how we can check if this issues is resolved.
@Ujjwal-UJ How is this PR coming? Are we still waiting on test cases? It looks as if the condition were were discussing has changed but I do not see any other commits?
@Ujjwal-UJ How is this PR coming? Are we still waiting on test cases? It looks as if the condition were were discussing has changed but I do not see any other commits?
@davidicus I was working on other issue, test cases are pending! will update that shortly
Code coverage is not lowered.
Existing code coverage:

Ujjwal PR (updated with commit 5cdeec5):

The added conditions are already covered by existing tests.