carbon-addons-iot-react
carbon-addons-iot-react copied to clipboard
Dynamic aggregation part2
Closes #3533
Summary
Updated logic to a call back for showing the DataSeriesFormItemModal Added a add Aggregations button to the modal
Change List (commits, features, bugs, etc)
CardEditForm.jsx CardEditFormContent.jsx DataSeriesFormItemModal.jsx DataSeriesFormItemModal.test DataSeriesFormItemContent.jsx DataSeriesFormItemContent.test ImageCardFormContent.jsx TableCardFormContent.jsx TableCardFormSettings.jsx TableCardFormSettings.test CardEditor.jsx CardEditor.Story Dashboard.Story DashboardEditor.jsx DashboardEditor.story DashboardEditor.test EditorUtils.jsx EditorUtils.test HotspotEditorDataSourceTab.jsx HotspotEditorDataSourceTab.test HotspotEditorDataSourceTab.story HotspotEditorModal.jsx HotspotEditorModal.test HotspotEditorModal.story HotspotEditorTooltipTab.story.jsx HotspotTextStyleTab.story.jsx
Test
- Check all Dashboard and CardEditor stories
- Check V2 Pressure story Edit a TimeSeries card and select V2 pressure you should see the add aggregation method button.
Regression Test (how to make sure this PR doesn't break old functionality)
- Check all Dashboard and CardEditor stories
Things to look for during review
- [ ] Make sure all references to
iot
orbx
class prefix is using the prefix variable - [ ] (React) All major areas have a
data-testid
attribute. New test ids should have test written to ensure they are not changed or removed. - [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
- [ ] All strings should be translatable.
- [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
- [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
- [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
- [ ] Changes or new components should either write new or update existing documentation.
- [ ] PR should link and close out an existing issue
Deploy Preview for carbon-addons-iot-react ready!
Name | Link |
---|---|
Latest commit | 2bdbf452462673de0cd4e0f5453604723a90833d |
Latest deploy log | https://app.netlify.com/sites/carbon-addons-iot-react/deploys/631890424039940008d43e5e |
Deploy Preview | https://deploy-preview-3531--carbon-addons-iot-react.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Deploy Preview for ai-apps-pal-angular ready!
Name | Link |
---|---|
Latest commit | 2bdbf452462673de0cd4e0f5453604723a90833d |
Latest deploy log | https://app.netlify.com/sites/ai-apps-pal-angular/deploys/631890420a2c1d0009b426bb |
Deploy Preview | https://deploy-preview-3531--ai-apps-pal-angular.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.