carbon-addons-iot-react icon indicating copy to clipboard operation
carbon-addons-iot-react copied to clipboard

feat(card): adding tooltip to the card extra actions

Open herleraja opened this issue 1 year ago • 4 comments

Closes https://github.com/carbon-design-system/carbon-addons-iot-react/issues/3526

Summary

  • adding tooltip to the card extra actions

Change List (commits, features, bugs, etc)

  • feat(card): adding tooltip to the card extra actions

Acceptance Test (how to verify the PR)

  • tooltips can be passed from the props

Regression Test (how to make sure this PR doesn't break old functionality)

  • card should work with out any issues

Things to look for during review

  • [ ] Make sure all references to iot or bx class prefix is using the prefix variable
  • [ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • [ ] All strings should be translatable.
  • [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
  • [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • [ ] Changes or new components should either write new or update existing documentation.
  • [ ] PR should link and close out an existing issue

herleraja avatar Aug 26 '22 15:08 herleraja

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 7bb3c9a4d666dedb699b76bcd51e2384f3e7cd60
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6315b1a9bbc0a800080049b2
Deploy Preview https://deploy-preview-3527--carbon-addons-iot-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 26 '22 15:08 netlify[bot]

Deploy Preview for ai-apps-pal-angular ready!

Name Link
Latest commit 7bb3c9a4d666dedb699b76bcd51e2384f3e7cd60
Latest deploy log https://app.netlify.com/sites/ai-apps-pal-angular/deploys/6315b1a96373ab0008ff2075
Deploy Preview https://deploy-preview-3527--ai-apps-pal-angular.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 26 '22 15:08 netlify[bot]

It does not explicitly state it in the spec but the dropdown convention is for the 3 dot which is how it is shown through out the spec. @dianatran18 is it cool to allow for different type of dropdown icons for the card?

davidicus avatar Aug 26 '22 16:08 davidicus

@dianatran18 is it allowed for different type of dropdown icons for the card ?

herleraja avatar Aug 31 '22 08:08 herleraja

merging issues, the branch seems to be not clean. So fixing the issue in https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3540

herleraja avatar Sep 06 '22 13:09 herleraja