carbon-addons-iot-react icon indicating copy to clipboard operation
carbon-addons-iot-react copied to clipboard

chore(angular): upgrade to angular 12

Open siddharthcr opened this issue 1 year ago • 6 comments

Closes #

Summary

Upgrading @ai-apps/angular to angular 12

Change List (commits, features, bugs, etc)

  • upgrade to angular 12
  • enabled 'partial' compilation mode with ivy
  • refactored code to remove circular dependency
  • upgraded storybook for to 6.5.9 and webpack 5
  • refactored stories to use new story format

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • [ ] Make sure all references to iot or bx class prefix is using the prefix variable
  • [ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • [ ] All strings should be translatable.
  • [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
  • [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • [ ] Changes or new components should either write new or update existing documentation.
  • [ ] PR should link and close out an existing issue

siddharthcr avatar Aug 10 '22 11:08 siddharthcr

Deploy Preview for ai-apps-pal-angular ready!

Name Link
Latest commit 8ffdf4d74b06d8cfe504fa65482d56b3cb907b32
Latest deploy log https://app.netlify.com/sites/ai-apps-pal-angular/deploys/62f40f20fab6ce0008166202
Deploy Preview https://deploy-preview-3518--ai-apps-pal-angular.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 11:08 netlify[bot]

Deploy Preview for carbon-addons-iot-react ready!

Name Link
Latest commit 8ffdf4d74b06d8cfe504fa65482d56b3cb907b32
Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/62f40f206496ce000a9301e1
Deploy Preview https://deploy-preview-3518--carbon-addons-iot-react.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 20:08 netlify[bot]

Also, format is failing, run yarn format:check for more details

Akshat55 avatar Aug 24 '22 15:08 Akshat55

@Akshat55 @zvonimirfras any updates here? Trying to close out any stale PRs

davidicus avatar Sep 29 '22 20:09 davidicus

I think we're not merging this at this point. @Akshat55 double check and close, pls 🙂

zvonimirfras avatar Oct 12 '22 15:10 zvonimirfras

@davidicus, we aren't merging this PR now as it contains breaking changes. Will be useful in future when carbon-addons-iot-react is updated to Carbon 11 though.

Akshat55 avatar Oct 12 '22 18:10 Akshat55

Closing for now. Feel free to re-open when ready.

davidicus avatar Jan 13 '23 19:01 davidicus