carbon-addons-iot-react icon indicating copy to clipboard operation
carbon-addons-iot-react copied to clipboard

[Table] [A11y] headers="expand" should be removed from first column <td>

Open valZho opened this issue 3 years ago • 1 comments
trafficstars

What package is this for?

  • [X] React
  • [?] Angular

Describe the bug

The 'headers' attribute with value "expand" does not reference a valid 'id' in the document

Expected behavior

The

tags for the first column (row expansion) in a table contain the property header="expand" which is supposed to point to the id of a cell, but none of the elements have ids (let alone something so generic). The header property should be removed.

Environment/versions:

  • carbon-addons-iot-react version: 2.150.0

Additional context

Screen Shot 2022-06-23 at 3 16 44 PM

valZho avatar Jun 23 '22 20:06 valZho

This attribute is coming from Carbon. After looking into their own issue for this the fix is to add id to their TableHeader component as they have done in this PR

davidicus avatar Jul 18 '22 14:07 davidicus

On next branch, I can still see headers='expand' on the TableExpandRow with no id. I can still see the a11y violations.

image

image

jessieyan avatar Oct 19 '22 18:10 jessieyan