carbon-addons-iot-react icon indicating copy to clipboard operation
carbon-addons-iot-react copied to clipboard

Published 20 hours ago • verified publisher icon carbon-design-system

[TableCard] Show table header behaviour is flipped

Open herleraja opened this issue 2 years ago • 2 comments

What package is this for?

  • [x] React
  • [ ] Angular

Describe the bug

Table card --> Show table header confusing. When we enable the toggle button it supposes to show the table header, whereas currently its hides the table header image

I think the property behavior is actually hideHeader instead of showHeader.

image

The regression seems to be introduced 3 months ago : https://github.com/carbon-design-system/carbon-addons-iot-react/commit/7ca8c1aa16001ddd2f880b875949f43e1a344c30

herleraja avatar May 23 '22 10:05 herleraja

This text is a translatable string that can be controlled at the application level. The text seen here are just the defaults. Passing showHeader to the DashboardEditor component will allow you to pass in any text you would like.

davidicus avatar May 31 '22 11:05 davidicus

We should update this text for the story when we migrate DashboardEditor out of experimental.

davidicus avatar May 31 '22 12:05 davidicus

The behavior is been flipped. Also by default, we should not hide the table column name. The regression seems to be introduced 7 months ago : https://github.com/carbon-design-system/carbon-addons-iot-react/commit/7ca8c1aa16001ddd2f880b875949f43e1a344c30

herleraja avatar Sep 05 '22 08:09 herleraja