carbon-addons-iot-react
carbon-addons-iot-react copied to clipboard
fix(tableCardFormContent): updating thresholds when dataItem is removed
Closes #https://github.com/carbon-design-system/carbon-addons-iot-react/issues/3389#issue-1175479330
Summary
- Thresholds not updating when a data item is removed
Change List (commits, features, bugs, etc)
- Added code to remove thresholds for a data items when the data item is removed
Acceptance Test (how to verify the PR)
- tests in storybook generated by pr
Regression Test (how to make sure this PR doesn't break old functionality)
- tests here
Things to look for during review
- [ ] Make sure all references to
iot
orbx
class prefix is using the prefix variable - [ ] (React) All major areas have a
data-testid
attribute. New test ids should have test written to ensure they are not changed or removed. - [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
- [ ] All strings should be translatable.
- [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
- [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
- [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
- [ ] Changes or new components should either write new or update existing documentation.
- [ ] PR should link and close out an existing issue
✅ Deploy Preview for carbon-addons-iot-react ready!
🔨 Explore the source changes: f557f6af8fa53d276f561a85a616624b55ac846d
🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/62388e3e7a3cc000082d8369
😎 Browse the preview: https://deploy-preview-3390--carbon-addons-iot-react.netlify.app
✅ Deploy Preview for ai-apps-pal-angular ready!
🔨 Explore the source changes: f557f6af8fa53d276f561a85a616624b55ac846d
🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/62388e3e57031f0008846bba
😎 Browse the preview: https://deploy-preview-3390--ai-apps-pal-angular.netlify.app
Can we link this PR to an issue and add a unit test? Preferably also add a link to acceptance test story with instructions. Thanks :-)
Fixed by other https://github.com/carbon-design-system/carbon-addons-iot-react/pull/3565