carbon-addons-iot-react icon indicating copy to clipboard operation
carbon-addons-iot-react copied to clipboard

[Table] incorrect PropTypes for emptyState

Open bjornalm opened this issue 2 years ago • 0 comments

What package is this for?

  • [x] React
  • [ ] Angular

Describe the bug

The Table has incorrect PropTypes for the prop view.table.emptyState. It uses EmptyStatePropTypes which defines a configuration object where all property values are of type PropTypes.node, but the actual underlying EmptyState component used expects strings for several of the props. This is true for message, messageWithFilters, buttonLabel and buttonLabelWithFilters. Only the actual messageBody can be a node.

To Reproduce

na

Expected behavior

PropTypes in EmptyStatePropTypes should match the types they are matched against in the underlying EmptyState component.

Environment/versions:

  • OS: [e.g. MacOS, Windows]
  • Browser: [e.g. chrome, safari]
  • carbon-addons-iot-react version: [e.g. v2.60.0]

Specific timeline issues / requests

Do you want this work within a specific time period? Is it related to an upcoming release?

NB: The core contributors will try to work with your timeline, but it's not guaranteed. The earlier you make a request in advance of a desired delivery date, the better!

bjornalm avatar Mar 03 '22 19:03 bjornalm