carbon-addons-iot-react
carbon-addons-iot-react copied to clipboard
fix(datetimepicker): add date picker parameters support
Closes #2861
Summary
- summary_here
Change List (commits, features, bugs, etc)
- items_here
Acceptance Test (how to verify the PR)
- tests here
Regression Test (how to make sure this PR doesn't break old functionality)
- tests here
Things to look for during review
- [ ] Make sure all references to
iotorbxclass prefix is using the prefix variable - [ ] (React) All major areas have a
data-testidattribute. New test ids should have test written to ensure they are not changed or removed. - [ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
- [ ] All strings should be translatable.
- [ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
- [ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
- [ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
- [ ] Changes or new components should either write new or update existing documentation.
- [ ] PR should link and close out an existing issue
✔️ Deploy Preview for ai-apps-pal-angular ready!
🔨 Explore the source changes: 306fed7ae2402e7e3f451a608db8930a99d5a86e
🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/61732fe68814a20008e23568
😎 Browse the preview: https://deploy-preview-2995--ai-apps-pal-angular.netlify.app
✔️ Deploy Preview for carbon-addons-iot-react ready!
🔨 Explore the source changes: 306fed7ae2402e7e3f451a608db8930a99d5a86e
🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/61732fe5e9916d0008abea00
😎 Browse the preview: https://deploy-preview-2995--carbon-addons-iot-react.netlify.app
✔️ Deploy Preview for ai-apps-pal-angular ready!
🔨 Explore the source changes: 11cfb1e54d739c586ca9ce34eec050bff8a91d03
🔍 Inspect the deploy log: https://app.netlify.com/sites/ai-apps-pal-angular/deploys/61fa9d85cbf5bd00071d4878
😎 Browse the preview: https://deploy-preview-2995--ai-apps-pal-angular.netlify.app
✔️ Deploy Preview for carbon-addons-iot-react ready!
🔨 Explore the source changes: 11cfb1e54d739c586ca9ce34eec050bff8a91d03
🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-addons-iot-react/deploys/61fa9d852274700008a085c9
😎 Browse the preview: https://deploy-preview-2995--carbon-addons-iot-react.netlify.app
@sophiiae can we get these merge conflicts addressed so we can merge this PR?
Hey @zvonimirfras can we get this updated so we can get this merged in or close out this issue? Let me know when you have pushed and I will get it merged ASAP. Thanks.
I am closing for lack of response. Feel free to re-open when ready.