carbon icon indicating copy to clipboard operation
carbon copied to clipboard

[BugFix] Fix exported image cut off - Safari

Open baruchadi opened this issue 2 years ago • 6 comments

when exporting on safari, the image is offset to the left by 50%. I adjusted the transform configuration to counter that position offset ONLY when Safari is detected in the user agent.

tested to work on the various resolutions (1x, 2x, 4x) for "download" and "open"

before: carbon-4

After: carbon-7

Closes #1351

baruchadi avatar Aug 21 '22 13:08 baruchadi

@baruchadi is attempting to deploy a commit to the Carbon Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 21 '22 13:08 vercel[bot]

In 4x mode, this hack may not work. Would you mind to provide an instance to test it?

pan93412 avatar Aug 21 '22 13:08 pan93412

👋 @pan93412 Here are the various exports in different resolutions:

[Safari Version 15.5 (17613.2.7.1.8)]

1x carbon-11

2x carbon-10

4x carbon-9

baruchadi avatar Aug 21 '22 13:08 baruchadi

Seems working as intended! 🎉

Thanks a lot to your work!

pan93412 avatar Aug 21 '22 13:08 pan93412

Hey all, who do I need to reach out to in order to get this PR reviewed & hopefully merged?

Cheers!

baruchadi avatar Sep 11 '22 20:09 baruchadi

r? @mfix22

pan93412 avatar Sep 11 '22 22:09 pan93412