carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Exported image cut off - Safari Technology Preview

Open terrymorse58 opened this issue 2 years ago • 7 comments

Describe the bug

When using the Safari Technology Preview browser (Release 141 (Safari 15.4, WebKit 17614.1.3.8)), the Export command produces an image that is shifted to the left by about half the image size, leaving the left half of the image off.

To Reproduce

  1. Open carbon.now.sh in Safari Technology Preview browser
  2. Click on 'Export'
  3. See the image in Downloads folder

Expected behavior Expected to see an image that isn't shifted and cropped.

Screenshots

Expected image:

carbon

Incorrect image:

carbon-bug

Info:

  • OS: macOS Monterey 12.12.1
  • Browser: Safari Technology Preview release 141
  • Carbon URL: carbon.now

terrymorse58 avatar Mar 22 '22 19:03 terrymorse58

It happens in the standard Safari 15.4 as well

cperezabo avatar Mar 23 '22 15:03 cperezabo

@terrymorse58 @cperezabo I just tried it out on basic Safari, and it is working for me. Please share a link to a Carbon snippet that reproduces this bug.

mfix22 avatar Apr 03 '22 02:04 mfix22

@terrymorse58 @cperezabo I just tried it out on basic Safari, and it is working for me. Please share a link to a Carbon snippet that reproduces this bug.

I can reproduce it:

https://user-images.githubusercontent.com/28441561/161749499-e54d4190-7160-49ab-978a-fb9422a00843.mov

pan93412 avatar Apr 05 '22 12:04 pan93412

It works properly when outputting in 1x size. Besides, outputting in 4x makes all the canvas white.

截圖 2022-04-05 下午8 03 28

1x

截圖 2022-04-05 下午8 04 33

4x

截圖 2022-04-05 下午8 04 48

pan93412 avatar Apr 05 '22 12:04 pan93412

I can reproduce all of above in Safari 15.4.

erikr avatar Apr 07 '22 13:04 erikr

@erikr @pan93412 @terrymorse58 @cperezabo @hatsu38 this seems to be a regression in Safari somehow. Would love some help finding a bug fix here, if any of you have the time.

mfix22 avatar May 14 '22 20:05 mfix22

👋 Hey there! I have a quick patch for this issue here: https://github.com/carbon-app/carbon/pull/1405

It's my first time contributing to Carbon, so if a repo owner can take a quick look I'd appreciate it (changed 2 lines of code) 🙏

Cheers!

baruchadi avatar Aug 21 '22 13:08 baruchadi