merlin icon indicating copy to clipboard operation
merlin copied to clipboard

No validation for Custom Transformer Docker Image Name

Open ariefrahmansyah opened this issue 4 years ago • 0 comments

Expected Behavior

Prevent user from submitting invalid custom Docker image name

Current Behavior

There's no validation for the Custom Transformer Docker Image name in the input-form, enabling the user to submit it and continue with the deployment. It leads to error creating inference service.

Steps to reproduce

  1. In the model deployment page, choose Custom Transformer
  2. In the Docker Image name, write an invalid docker name. For example, add a space between the name and tag: my-image-name: my-tag
  3. Click Deploy
  4. The UI will display success, but after waiting, the deployment will be failed with the error message: error creating inference service

Possible Solution

Add validation.

*We may need to check for another validation needed in other input components.

ariefrahmansyah avatar Feb 09 '21 07:02 ariefrahmansyah