merlin icon indicating copy to clipboard operation
merlin copied to clipboard

chore(api): Update go dependencies in merlin api server

Open deadlycoconuts opened this issue 1 year ago • 2 comments

Description

This MR basically bumps a couple of Go package dependencies used by the Merlin API server, which in turn is imported by the Turing API server and will have its own dependencies updated in a separate PR (the updates in the PR will allow the dependencies of the Turing API server to also be updated without having to be pinned to the versions used in the Merlin API server). The version of Go used has also been bumped up from 1.20 to 1.22.

Main packages updated:

- github.com/GoogleCloudPlatform/spark-on-k8s-operator
- github.com/google/go-containerregistry 
- github.com/kserve/kserve
- k8s.io/api 
- k8s.io/apimachinery
- k8s.io/client-go
- knative.dev/networking
- knative.dev/pkg
- knative.dev/serving
- sigs.k8s.io/controller-runtime

Some minor refactoring was performed on structs that may have changed or on functions called due to the changes in their expected argument - these are annotated directly on the diffs.

Modifications

  • api/cluster/controller.go - Updated the KServe controller functions as they now require a context
  • api/cluster/resource/templater.go - Updated the Handler field of a Probe struct to a ProbeHandler field
  • api/go.mod - Updated various packages here

Tests

Checklist

  • [x] Added PR label
  • [ ] Added unit test, integration, and/or e2e tests
  • [x] Tested locally
  • [ ] Updated documentation
  • [ ] Update Swagger spec if the PR introduce API changes
  • [ ] Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

deadlycoconuts avatar Mar 12 '24 06:03 deadlycoconuts

@deadlycoconuts can you help update/rebase your branch?

You should be able to do it from UI by clicking the Update branch button: image

ariefrahmansyah avatar Apr 01 '24 08:04 ariefrahmansyah

Thanks for the reminder; I just rebased my branch! :D So many PRs being merged during this short time x_x

deadlycoconuts avatar Apr 01 '24 09:04 deadlycoconuts

Thanks a lot for the review @ariefrahmansyah ! :D I'll be merging this now!

deadlycoconuts avatar Apr 08 '24 03:04 deadlycoconuts