husky icon indicating copy to clipboard operation
husky copied to clipboard

No name shown in 'replying to' section of post when using Mitra

Open watamelonman opened this issue 1 year ago • 10 comments

General description of the issue

When using Husky with an account on a Mitra instance, replies do not show the target of said reply. There is only blank space next to the 'replying to' section. This blank space happens on all posts regardless of origin (e.g. whether it's from a Pleroma instance, Mastodon, Misskey, Mitra, etc.). This isn't a problem when viewing the same posts from Mitra's web UI. Screenshot_20240521-114353

Husky information

  • Husky version: 1.5.4
  • Android version: 14
  • Android ROM version: CalyxOS 5.7.0

Mitra version of instance

  • Mitra v2.18

Steps to reproduce it

Please, describe the steps to reproduce the issue:

  1. Log into Mitra instance account on Husky
  2. View any post that is a reply

Where did you get Husky from:

  • [X] F-Droid.
  • [ ] Self-releases.
  • [ ] Play Store.
  • [ ] Self-compiled (specify tag/commit).

watamelonman avatar May 21 '24 15:05 watamelonman

If Mitra implements the ActivityPub API as Pleroma or Mastodon does, it should show it. I'll take a look, but it's probably not Husky's fault.

captainepoch avatar May 22 '24 10:05 captainepoch

@captainepoch Sure, looks like a problem is on the Mitra side. Could you tell where data for this UI element comes from? I'd expect it to be Status.in_reply_to_id or Status.in_reply_to_account_id, but Mitra provides both, so it must be something else?

silverpill avatar May 24 '24 13:05 silverpill

If it provides any of those (but I think the correct one is in_reply_to_account_id), it should show.

Nevertheless, I still have my account in your Mitra instance, so I'll take a look.

captainepoch avatar May 27 '24 13:05 captainepoch

As far as I can see, in_reply_to_account_id is null (see attached image).

Captura de Pantalla 2024-05-28 a las 20 20 49

captainepoch avatar May 28 '24 18:05 captainepoch

Yes, but on this image in_reply_to_id is also null, so it is probably not a reply?

silverpill avatar May 28 '24 20:05 silverpill

You're right about that, I made the screenshot about the wrong value. It is, indeed, with information about the account.

It seems, in the end, a Husky issue, so I'll do more research on why this is happening.

Captura de Pantalla 2024-05-28 a las 22 27 16

captainepoch avatar May 28 '24 20:05 captainepoch

I didn't forget about this, I'm still investigating why it's happening.

captainepoch avatar Jun 29 '24 07:06 captainepoch

Hello!

I finally detected what's the issue is here.

Pleroma and Mastodon (I globalize also their forks) include the username in the reply's response Json by the field in_reply_to_account_acct. If the user is at the same instance, it doesn't show the @stereophonic.space (as an example), and if it's not at the same instance, it does (see screenshots attached).

Mitra should do the same. Captura de Pantalla 2024-07-10 a las 19 38 49

Captura de Pantalla 2024-07-10 a las 19 39 20

captainepoch avatar Jul 10 '24 17:07 captainepoch

I haven't found this field in Mastodon responses, but Pleroma includes pleroma.in_reply_to_account_acct and I added it too. @watamelonman said that fixed the problem, so we can close the issue now.

Thank you!

silverpill avatar Jul 11 '24 11:07 silverpill

You're totally right about this, and it happens on Mastodon instances using Husky, thank you very much for noticing it.

I'll try to come up with a fix, in case you want to remove this fied, so it works for both of the backends.

Again, thank you!

captainepoch avatar Jul 11 '24 12:07 captainepoch

I tested this with Mitra 4.9.0 and Husky 1.7.0-beta1, I think it works now:

Image

Could you let me know?

captainepoch avatar Sep 16 '25 05:09 captainepoch

Yeah, I think it was fixed. Nobody complained about the bug since then.

silverpill avatar Sep 17 '25 19:09 silverpill

Closing it, then. Cheers!

captainepoch avatar Sep 18 '25 05:09 captainepoch