capstone-rs icon indicating copy to clipboard operation
capstone-rs copied to clipboard

Reduce number of disasm*() methods

Open tmfink opened this issue 5 months ago • 2 comments

Address comments from: https://github.com/capstone-rust/capstone-rs/pull/115#pullrequestreview-3050330818

tmfink avatar Jul 24 '25 07:07 tmfink

There is a small place where the existing disasm_all/disasm_count is more convenient: disasm_iter does not allow having two Insn at the same time (due to sharing their details pointer).

jiegec avatar Jul 25 '25 02:07 jiegec

There is a small place where the existing disasm_all/disasm_count is more convenient: disasm_iter does not allow having two Insn at the same time (due to sharing their details pointer).

Therefore, I prefer to keep the existing ones and suggest performance-sensitive users to switch over.

jiegec avatar Jul 30 '25 09:07 jiegec