capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Python2 leftovers v2

Open twizmwazin opened this issue 1 year ago • 4 comments

Your checklist for this pull request

  • [x] I've documented or updated the documentation of every API function and struct this PR changes.
  • [x] I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Rebases #2378 onto next, adds a commit updating shebangs to python3, I only found one.

...

Test plan

...

Closing issues

...

twizmwazin avatar Jun 28 '24 20:06 twizmwazin

I also noticed that there are some files in suite that are unported. Do we need to port those?

twizmwazin avatar Jun 29 '24 05:06 twizmwazin

Most of the suite files probably should be removed as they are deprecated in favor of auto-sync tools.

XVilka avatar Jun 29 '24 06:06 XVilka

Most of the suite files probably should be removed as they are deprecated in favor of https://github.com/capstone-engine/capstone/issues/2015 tools.

Yes, but let's do this before v6 (not here). Because they are not used. But this code here is run in the CI. Cleaning up suite is more than just the Pythin 2 files.

Rot127 avatar Jun 29 '24 06:06 Rot127

@twizmwazin Any chance you find time to finish https://github.com/capstone-engine/capstone/pull/2369 on behalf of @pyrox0? It is the only one for v5.0.2

Rot127 avatar Jun 29 '24 06:06 Rot127