capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Published 20 hours ago • verified publisher icon capstone-engine

Makefile: Improve Apple detection

Open sevan opened this issue 1 year ago • 9 comments

__APPLE__ is always defined & set to 1 on Darwin. __apple_build_version__ not available on older releases. This change allows Capstone to build on OS X 10.4.

sevan avatar Feb 03 '24 02:02 sevan

Note though that the Makefile build method is effectively deprecated and will be dropped in the future.

Rot127 avatar Feb 03 '24 03:02 Rot127

Understood. It would be a shame since cmake has such a high cost. I can build capstone 5.0.1 with GCC 4.0 on OS X 10.4, but cmake needs a C++11 compiler from cmake 3.10 onwards & may need an even more recent C++ compiler on current releases, so effectively that will become capstone's minimum requirement.

sevan avatar Feb 03 '24 03:02 sevan

Just opened an issue where you can describe your use case. So we have tracked it somewhere (https://github.com/capstone-engine/capstone/issues/2264). @kabeor, please trigger the CI.

Rot127 avatar Feb 03 '24 08:02 Rot127

Thanks, I'll follow up there later on tonight when I have some time. Just popped in to ask if something is wrong on the CI side?

sevan avatar Feb 03 '24 12:02 sevan

@Rot127 Is there something wrong with the CI here or have I missed where it's going wrong?

sevan avatar Feb 06 '24 16:02 sevan

Yeah, something is broken currently.

Rot127 avatar Feb 06 '24 16:02 Rot127

No worries. Thanks for the sanity check. :)

sevan avatar Feb 06 '24 16:02 sevan

https://github.com/capstone-engine/capstone/commit/6a55ef3bdadf606b79a954adad80a90913e6b519 should fix the CI, please push a commit to trigger it.

kabeor avatar Feb 15 '24 06:02 kabeor

Done.

sevan avatar Feb 15 '24 11:02 sevan

Cool, thanks!

kabeor avatar Feb 23 '24 05:02 kabeor