capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Add general encoding information for instructions

Open Rot127 opened this issue 1 year ago • 2 comments

Adds the encoding information for each instruction. @AngelDev06 did the first implementation in https://github.com/capstone-engine/capstone/pull/2045

This PR adds a few changes:

  • [ ] Rename ARM_MEM_FMT to something ISA or LLVM related. The current names are rather arbitrary and don't relate to the formatting as described in the ISA or LLVM definitions. Which makes it difficult to determine which encoding corresponds to which one in the ISA.
  • [ ] Add an enum for ISA instruction formats for ARM (if possible). According to C2.1 (document DDI0553B.v)

more?

Rot127 avatar Jan 03 '24 16:01 Rot127

@AngelDev06 Any objections against this (https://github.com/capstone-engine/capstone/pull/2231/commits/cff87a38061edb2a8968ef37cef6e0642bef6332) naming convention?

Rot127 avatar Jan 14 '24 13:01 Rot127

@Rot127 None. I like it more than my version, which was a little rushed. It's better that you can now refer to the documentation rather than trying to make sense from comments.

AngelDev06 avatar Jan 14 '24 13:01 AngelDev06

Closed due to: https://github.com/capstone-engine/capstone/pull/2045#issuecomment-2068848678

Rot127 avatar Apr 22 '24 08:04 Rot127