Breaking Change: Don't add capstone dir to include search path

Open autoantwort opened this issue 2 years ago • 1 comments

Main motivation: This is what the installed cmake config does: https://github.com/capstone-engine/capstone/blob/5fb8a423d4455cade99b12912142fd3a0c10d957/CMakeLists.txt#L628-L630

Also capstone has very generic header names that could collide with other projects:

https://github.com/capstone-engine/capstone/issues/1982 https://github.com/wolfpld/tracy/issues/547

Oct 20 '23 16:10 autoantwort

that's a regression workarounded in r2 https://github.com/radareorg/radare2/commit/ed90a9007f6d2904b603bb2bb4ee6bd6688f09d6

Oct 22 '23 21:10 trufae