capstone icon indicating copy to clipboard operation
capstone copied to clipboard
verified publisher icon capstone-engine

5.0.x release suggestions

Open XVilka opened this issue 2 years ago • 24 comments

Would be nice to have fixes for these in the patch release:

5.0.1

  • [x] https://github.com/capstone-engine/capstone/issues/2066
  • [x] https://github.com/capstone-engine/capstone/pull/2080
  • [x] https://github.com/capstone-engine/capstone/pull/2086
  • [x] https://github.com/capstone-engine/capstone/pull/2095
  • [x] https://github.com/capstone-engine/capstone/pull/2096
  • [x] https://github.com/capstone-engine/capstone/pull/2097
  • [x] https://github.com/capstone-engine/capstone/pull/2088
  • [x] https://github.com/capstone-engine/capstone/pull/2090
  • [x] https://github.com/capstone-engine/capstone/pull/2100
  • [x] https://github.com/capstone-engine/capstone/pull/2108
  • [x] https://github.com/capstone-engine/capstone/pull/2134

5.0.2

  • [ ] https://github.com/capstone-engine/capstone/issues/2154
  • [x] https://github.com/capstone-engine/capstone/issues/2145
  • [ ] https://github.com/capstone-engine/capstone/issues/2144
  • [ ] https://github.com/capstone-engine/capstone/issues/2147
  • [ ] https://github.com/capstone-engine/capstone/issues/2079
  • [ ] https://github.com/capstone-engine/capstone/issues/2128
  • [ ] https://github.com/capstone-engine/capstone/issues/2025
  • [ ] https://github.com/capstone-engine/capstone/issues/2005
  • [ ] https://github.com/capstone-engine/capstone/issues/1955 (if it still happens)
  • [ ] https://github.com/capstone-engine/capstone/issues/1893
  • [ ] https://github.com/capstone-engine/capstone/pull/2148
  • [ ] https://github.com/capstone-engine/capstone/issues/2153
  • [ ] Publish news on http://www.capstone-engine.org/ for the 5.0.2 release

After they are fixed in the next branch, fixes could be cherry-picked to the v5 branch one by one for the release.

XVilka avatar Jul 10 '23 10:07 XVilka

There are also many PPC regressions found by @wargio but they will be fixed in the https://github.com/capstone-engine/capstone/pull/2013 so it doesn't make sense trying to fix them in the patch release.

XVilka avatar Jul 11 '23 04:07 XVilka

@kabeor you need to cherry-pick corresponding commits from next to v5: https://github.com/capstone-engine/capstone/tree/v5

XVilka avatar Jul 21 '23 16:07 XVilka

Well looks like there are some misunderstood. v5 should merge something only if we are ready to release a version. so I think we needn't cherry-pick.

kabeor avatar Jul 21 '23 16:07 kabeor

@kabeor but you already cherry-picked some of these fixes - SH and ARM VFP fix. Idea is to cherry-pick these fixes and tag 5.0.1

XVilka avatar Jul 21 '23 16:07 XVilka

@XVilka Aha @aquynh did this. I should talk with him about this tmw😂

kabeor avatar Jul 21 '23 16:07 kabeor

Looks like only x86 regression and deprecated modules left in this list, the rest was merged

XVilka avatar Jul 25 '23 02:07 XVilka

also the ppc regressions

wargio avatar Jul 25 '23 07:07 wargio

@wargio there are way too many, not sure if it makes sense to devote time instead of investing time in auto-sync PPC

XVilka avatar Jul 25 '23 13:07 XVilka

@kabeor Could we add a note to the 5.0.1 release, that the v6 release will bring some big changes (possibly linking to https://github.com/capstone-engine/capstone/pull/2124)? In this case people have the chance to decide if they might want to skip v5 altogether.

Rot127 avatar Jul 25 '23 15:07 Rot127

@Rot127 ok, it's a perfect time to announce that.

kabeor avatar Jul 26 '23 07:07 kabeor

@kabeor Great! You can link to the WIP release text here or to the PR.

Rot127 avatar Jul 26 '23 09:07 Rot127

@kabeor Could you please also a line that everyone is welcome to give early feedback regarding v6. The whole auto-sync thing still misses more eyes from the outside. And new releases have definitely more impact than issues.

Rot127 avatar Jul 26 '23 11:07 Rot127

@kabeor @aquynh I suggest to cherry-pick already existing fixes and tag 5.0.1 Not everything was fixed but some most annoying things were fixed already - the rest could land in 5.0.2 or something like that.

XVilka avatar Aug 04 '23 03:08 XVilka

@kabeor @aquynh ping

XVilka avatar Aug 14 '23 03:08 XVilka

@kabeor @aquynh ping

XVilka avatar Aug 19 '23 12:08 XVilka

#2141

kabeor avatar Aug 21 '23 03:08 kabeor

Thank you, @kabeor!

XVilka avatar Aug 21 '23 04:08 XVilka

@kabeor looks like some assets missing from the release?

XVilka avatar Aug 23 '23 02:08 XVilka

@XVilka I see. Reference to Docs: Workflows are not triggered for the created, edited, or deleted activity types for draft releases.. Maybe published field will fix this. Will test on next release.

kabeor avatar Aug 23 '23 04:08 kabeor

@gerph added your issues here. Worth carving a quick 5.0.2 bugfix release when fixes are available.

XVilka avatar Aug 24 '23 00:08 XVilka

@gerph added your issues here. Worth carving a quick 5.0.2 bugfix release when fixes are available.

Thanks :-)

There's no ticket for it, but it probably should apply to all the releases... a reminder to update the cs_version so that each release could be differentiated, would be good.

gerph avatar Aug 24 '23 18:08 gerph

@XVilka Could you add https://github.com/capstone-engine/capstone/issues/2177 and https://github.com/capstone-engine/capstone/issues/2174 to the list?

Rot127 avatar Oct 21 '23 14:10 Rot127

@XVilka This small problem can also be fixed issues： #2177

No-47 avatar Oct 23 '23 02:10 No-47

@kabeor for 5.0.2 please cherry-pick https://github.com/capstone-engine/capstone/pull/2221 then.

XVilka avatar Jan 21 '24 03:01 XVilka

Close this because we now track issues with milestones, see: https://github.com/capstone-engine/capstone/milestone/4

Rot127 avatar Mar 20 '24 04:03 Rot127