capstone icon indicating copy to clipboard operation
capstone copied to clipboard

Published 20 hours ago • verified publisher icon capstone-engine

Add aarch64 wheel build support

Open odidev opened this issue 3 years ago • 5 comments

Added aarch64 wheel build support. Related to https://github.com/aquynh/capstone/issues/1768, @veritas501 Could you please review this PR?

odidev avatar Jun 23 '21 13:06 odidev

I built the aarch64 wheel with the dockcross/manylinux2014-aarch64 image. Although the artifacts are built for aarch64, the wheel name shows capstone-5.0.0-py2.py3-none-manylinux2014_x86_64.whl. Could you please share your opinion on whether to rename the wheel name or build wheels with manylinux containers?

odidev avatar Jul 28 '21 06:07 odidev

I built the aarch64 wheel with the dockcross/manylinux2014-aarch64 image. Although the artifacts are built for aarch64, the wheel name shows capstone-5.0.0-py2.py3-none-manylinux2014_x86_64.whl. Could you please share your opinion on whether to rename the wheel name or build wheels with manylinux containers?

@chfl4gs, any thoughts on this? Thanks.

odidev avatar Oct 20 '21 08:10 odidev

@chfl4gs please can you ack this?

aquynh avatar Nov 09 '21 16:11 aquynh

@chfl4gs, Could you please have a look at this?

odidev avatar Apr 05 '22 06:04 odidev

Imo, you should be using cibuildwheel for building wheels. It can completely automate building wheels for many architectures, including aarch64, on macOS, Linux, and Windows. And it's supported by the PyPA so is regularly updated.

I may create a PR to switch capstone to using cibuildwheel, as I'd like macOS wheels…

flit avatar Apr 21 '22 16:04 flit

@flit

I may create a PR to switch capstone to using cibuildwheel, as I'd like macOS wheels…

It's a good time to do that since capstone is about to release 5.0

XVilka avatar Jun 30 '23 14:06 XVilka

More kind of wheel supports has been adding in #2099. Thanks again for your contribution. Closed.

kabeor avatar Jul 21 '23 15:07 kabeor