capstone icon indicating copy to clipboard operation
capstone copied to clipboard

try to add br_table detail

Open SpikeI opened this issue 6 years ago • 3 comments

Try to add brtable detail in disasm. I use malloc to get dynamic memory cost, but can't find a way to free it.

SpikeI avatar Mar 18 '19 08:03 SpikeI

sounds like we need to extend cs_free() with a csh handle to free this brtable.

aquynh avatar Mar 18 '19 16:03 aquynh

sounds like we need to extend cs_free() with a csh handle to free this brtable.

If we free it in cs_close(), we should get memory pointer from cs_struct?

SpikeI avatar Mar 19 '19 09:03 SpikeI

No, we need to free memory of instructions (generated by cs_disasm()), but not to close engine (with cs_close())

aquynh avatar Mar 19 '19 09:03 aquynh

Thank you for the PR! I closed it because it is out of date. With the new auto-sync update for v6 we made many changes to some main architectures and will do also to others. This also changed the requirements we have now for new PRs.

If you still want to merge the changes, please rebase your fix onto the newest next branch and open a new PR.

Rot127 avatar Mar 20 '24 09:03 Rot127