caprover-cli icon indicating copy to clipboard operation
caprover-cli copied to clipboard

Extra CR needed

Open nixilb opened this issue 4 years ago • 2 comments

There is a extra CR needed at this step that makes people wait "forever" Capture

nixilb avatar Feb 11 '21 14:02 nixilb

After some debugging, this seems to be a bug in the inquirer package (or possibly readline itself) when you use an asynchronous when that returns false, like caprover does here:

https://github.com/caprover/caprover-cli/blob/d20488cf70c956b92e051c09320741fcb6bc62af/src/utils/CliHelper.ts#L197

The above option is used from the deploy command at the following line: https://github.com/caprover/caprover-cli/blob/d20488cf70c956b92e051c09320741fcb6bc62af/src/commands/deploy.ts#L117

I was able to reproduce in my own project with the latest inquirer version. I'll do more debugging and possibly open an issue there (edit: issue at https://github.com/SBoudrias/Inquirer.js/issues/1062)

baileyherbert avatar Nov 02 '21 08:11 baileyherbert

Why this very small bug still didn't merged to latest stable build. I was deploying caprover first time and I just reinstalled whole system just because I thought something wrong in the captain server. Pretty annoying bug.

emirefek avatar Aug 03 '22 19:08 emirefek